WPF DataBinding (CommandParameter not working)

Question

I can't get my binding to work. My ActiveView has a ListView (x:Name="MyListView") as well as a view model as it's data context.

I have the following RibbonButton (RibbonControlLibrary):

<r:RibbonButton Label="Update Software" 
    LargeImageSource="/Ganymed.App.UI;component/Images/plain-update.png"
    Command="{Binding ActiveView.DataContext.UpdateSoftwareCommand}"
    CommandParameter="{Binding ActiveView.MyListView.SelectedItems}"/>

The command binding itself works fine. But I can't get the CommandParameter to work. I want to sent along the selected items of the ActiveView's ListView in order to decide whether or not to enabled the command. Am I missing something when binding the CommandParameter?

To clarify the structue:

MainWindow.xaml (contains the RibbonButton, DataContext = MainWindowViewModel)

MainWindowViewModel.cs contains the property ActiveView

ActiveView (contains the MyListView, DataContext = ActiveViewViewModel)

ActiveViewViewModel.cs contains the UpdateSoftwareCommand

Any help would be great. Thanks

Shouldn't it bee ActiveView.MyListView instead of ActiveView.ListView, cause you say the name is "MyListView" ? — SvenG
– SvenG, Commented Mar 16, 2012 at 15:09
Hi that was my fault when copying the code. I have changed the name in the example to not confuse anybody else. — Thomas Huber
– Thomas Huber, Commented Mar 16, 2012 at 15:14
How does your code for UpdateSoftwareCommand look like? If you use DelegateCommand then you should use DelegateCommand<TypeOfCommandParameter> version — Nikolay
– Nikolay, Commented Mar 16, 2012 at 15:24
In our software solution we have an ActionCommand : ICommand implementation which we use as commands. — Thomas Huber
– Thomas Huber, Commented Mar 16, 2012 at 15:26

denis morozov · Accepted Answer · 2012-05-06 14:27:50Z

1

One possibility :

 CommandParameter="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type r:RibbonButton}}, Path=SelectedItems}"

Another, you could just add a property SelectedItems to your ViewModel, bind it and have it always in sync and ready for command to operate on

edited May 6, 2012 at 14:27

answered Mar 16, 2012 at 21:11

denis morozov

6,3343 gold badges34 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Thomas Huber Over a year ago

Your solution is not working. I guess it is not working since the ListView is not an Ancestor of the Button within the Visual Tree.

denis morozov Over a year ago

Sorry, I meant to put as the ancenstor whatever control that has the Binding to your ViewModel

Collectives™ on Stack Overflow

WPF DataBinding (CommandParameter not working)

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related