simple php foreach loop help needed

Question

I have a for each loop like this

      $sn_count = 1;
      $prodfilter = "";
      foreach($prods as $prod){
        $prodfilter .= "<div class=\"product\">".$prod['product'][1]."</div>";
        $sn_count++;
      }
      echo $prodfilter;

Now my problem my "product" class displaying border even if the $prod['product'][1] not available. So i would like to test it using if statement.

If (product value available) {
$prodfilter .= "<div class=\"product\">".$prod['product'][1]."</div>";
}

I tried like this.

if(!empty($prod['product'][1])) {
$prodfilter .= "<div class=\"product\">".$prod['product'][1]."</div>";
 }

But its not working.

Wait, your loop iterates on $steps but you are testing and outputting $prod... ?? You'll get the same thing out for each loop iteration. — Michael Berkowski
– Michael Berkowski, Commented Mar 22, 2012 at 0:33
@Michael: I noticed that too, but I'm assuming he left out other code to shorten it. — Evan Mulawski
– Evan Mulawski, Commented Mar 22, 2012 at 0:34

Jaspreet Chahal · Accepted Answer · 2012-03-22 00:34:26Z

1

you can try couple of things

try this for a start

if(strlen(trim($prod['product'][$sn_count]))>0) {
 $prodfilter .= "<div class=\"product\">".$prod['product'][$sn_count]."</div>";
  }

or

if(isset($prod['product'][$sn_count])) {
 $prodfilter .= "<div class=\"product\">".$prod['product'][$sn_count]."</div>";
  }

answered Mar 22, 2012 at 0:34

Jaspreet Chahal

2,7601 gold badge17 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Luc M Over a year ago

It will give you warnings that the key does not exist if it doesn't exist.

Jaspreet Chahal Over a year ago

thats right. Dirty trick is to prepend @ to $prod to suppress the warnings ;) which off course is not preferred by will work.

Enrico · Accepted Answer · 2012-03-22 01:35:08Z

1

The right thing in my opinion would be to check how many rows returned. I'll assume you are using MySQL since you did not specify. Please ask for additional help if you are not using it.

http://www.php.net/manual/en/function.mysql-num-rows.php

if (mysql_num_rows($prods)!=0) {
    //Do your code
}

This should check if your query returned more than 0 rows (so it needs to be drawn). Does it fix it?

answered Mar 22, 2012 at 1:35

Enrico

90310 silver badges22 bronze badges

Comments

Andreas Hagen · Accepted Answer · 2012-03-22 00:36:33Z

0

The right thing to do is to check if it's empty as you tried, but since it fails there obviously is some data there. You could do a var_dump and figure out what and why it is there which probably leads you to the source of the problem.

If by available you mean declared then isset is the right function to use by the way.

answered Mar 22, 2012 at 0:36

Andreas Hagen

2,3452 gold badges19 silver badges34 bronze badges

Collectives™ on Stack Overflow

simple php foreach loop help needed

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related