NHibernate 3.1 nested where clause using LINQ doesn't create proper SQL

Question

I have the following Nhibernate LINQ query:

var query = from c in session.Query<Customer>()
            where
                c.EmailAddress == customer.EmailAddress ||
                (
                    c.Address1 == customer.Address1 &&
                    c.City == customer.City &&
                    c.State == customer.State &&
                    c.Postal == customer.Postal &&
                    c.FirstName == customer.FirstName &&
                    c.LastName == customer.LastName
                )
                select c;

I expected the resulting SQL statement to look like:

select
    ...
from
    dbo.Customers customer0_ 
where
    customer0_.EmailAddress=@p0 or 
    (
        customer0_.Address1=@p1 
        and customer0_.City=@p2 
        and customer0_.State=@p3 
        and customer0_.Postal=@p4 
        and customer0_.FirstName=@p5 
        and customer0_.LastName=@p6;
    )

But what I see from the debug log is:

select
    ...
from
    dbo.Customers customer0_ 
where
    customer0_.EmailAddress=@p0 
    or customer0_.Address1=@p1 
    and customer0_.City=@p2 
    and customer0_.State=@p3 
    and customer0_.Postal=@p4 
    and customer0_.FirstName=@p5 
    and customer0_.LastName=@p6;

Notice there is no grouping on the address part of the where clause. Is this intentional? Should I be formatting my query a different way, or is this a bug?

I suspect you need to upgrade to 3.2 (or latest from trunk) as 3.1 linq was not fully featured. — Rippo
– Rippo, Commented Mar 23, 2012 at 6:17
The assembly with this code was referencing 3.1 (came with Fluent Nhibernate nuget package), but the main project was referencing 3.2, with a binding redirect, so the actual live code should have been using 3.2, no? — Chris
– Chris, Commented Mar 23, 2012 at 13:08
possible duplicate of Grouping in condition is being dropped — Diego Mijelshon
– Diego Mijelshon, Commented Mar 24, 2012 at 16:08

Diego Mijelshon · Accepted Answer · 2012-03-24 16:08:48Z

1

The generated SQL is correct; the parentheses are not needed.

answered Mar 24, 2012 at 16:08

Diego Mijelshon

52.7k16 gold badges119 silver badges159 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Chris Over a year ago

Absolutely correct, but thanks for including the link in the comments that explains exactly why.

Collectives™ on Stack Overflow

NHibernate 3.1 nested where clause using LINQ doesn't create proper SQL

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related