why the javascript variable doesn't change among function?

Question

my problem with the following javascript function:

function ValidateDates() {

var valid = false;
birthD = $("#cp1_txtBirthDate").val();
initialD = $("#cp1_txtInitialDate").val();
var regexp = new RegExp("^([1-9]|(0|1|2)[0-9]|30)(/)([1-9]|1[0-2]|0[1-9])(/)((20|19|18)[0-9]{2})$");

if (birthD != "__/__/____" && initialD != "__/__/____") {
    if (regexp.test(initialD) && regexp.test(birthD)) {

        $.get("ValidateDates.aspx?BirthD=" + birthD + "&InitialD=" + initialD, function (data) {
            if (data == 0) {
                valid = true;

                $("#Dates_span").html("");
            }

            else {
                $("#Dates_span").html("*" + data);
                valid = false;

            }

        });

    }
}

return valid;
}

here when i check the variable valid i found it "false" even if its true, because the initial for it is false from the beginning of function so how to solve it and what is wrong?

You have not described clearly what is wrong.

gideon
– gideon

2012-03-26 08:56:23 +00:00
Commented Mar 26, 2012 at 8:56 — gideon
– gideon, Commented Mar 26, 2012 at 8:56

Matthew Flaschen · Accepted Answer · 2012-03-26 08:57:14Z

6

When you're doing an asynchronous call, you can't return a value like that. Instead, you should pass in a callback:

function ValidateDates(callback) {

    var valid = false;
    birthD = $("#cp1_txtBirthDate").val();
    initialD = $("#cp1_txtInitialDate").val();
    var regexp = new RegExp("^([1-9]|(0|1|2)[0-9]|30)(/)([1-9]|1[0-2]|0[1-9])(/)((20|19|18)[0-9]{2})$");

    if (birthD != "__/__/____" && initialD != "__/__/____") {
        if (regexp.test(initialD) && regexp.test(birthD)) {

            $.get("ValidateDates.aspx?BirthD=" + birthD + "&InitialD=" + initialD, function(data) {
                if (data == 0) {
                    valid = true;

                    $("#Dates_span").html("");
                }

                else {
                    $("#Dates_span").html("*" + data);
                    valid = false;

                }
                callback(valid);
            });
        }
    }
}

Then, call it like:

ValidateDates(function(isValid)
{
   // Do something with isValid
});

answered Mar 26, 2012 at 8:57

Matthew Flaschen

286k53 gold badges523 silver badges554 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

special life Over a year ago

sorry but i am stuck with something, i want the returned value to use it in if condition with other function like this :if (Page_ClientValidate() && ValidateName() && ValidNull && ValidateDates) so how to deal with this?

Matthew Flaschen Over a year ago

If ValidateDates is the only async one, you can just put the others inside the function. Otherwise, you can chain the async calls using multiple functions.

special life Over a year ago

how to make chain because i have many ajax calls for validation and i am using validatePage function that contains all validation to check before submit the page as "client side function" and "has returned value true or false

Matthew Flaschen Over a year ago

@speciallife, you could make a server-side wrapper function to do all the validation in one AJAX call. Alternatively, see this answer.

scibuff · Accepted Answer · 2012-03-26 08:57:40Z

1

What's wrong is that $.get is an asynchronous call, what that means is that the function doesn't wait until the result is returned from $.get call. It just makes the call and continues execution - so valid = true is set long after false has been returned.

answered Mar 26, 2012 at 8:57

scibuff

13.8k2 gold badges30 silver badges34 bronze badges

Collectives™ on Stack Overflow

why the javascript variable doesn't change among function?

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related