How can I replace the onclick action (with regex) using javascript / jQuery?

Question

How can I use jQuery to replace part of the onclick property / attribute? In the example below I would like to replace delete_image with do_delete_image:

Sample HTML

<a href="#" onclick="delete_image(1234)" >Delete Image</a>

My Attempt

jQuery('a').each(function(){
    var action = $(this).prop('onclick').replace('delete_image','do_delete_image');
    $(this).prop('onclick',action);
});

Error

Google chrome is throwing this error:

TypeError: Object function onclick(event) { delete_image(1234);return false; } has no method 'replace'

How can I make this work? ps: This is a bookmarklet set to work with someone else's code.

Ry- · Accepted Answer · 2012-03-28 03:07:28Z

2

onclick is a property representing the function that handles the click event. To get and set the actual content, use attr instead of prop.

Alternatively, consider replacing delete_image with do_delete_image, for example:

window.delete_image = window.do_delete_image;

You can combine this with closures if you need to wrap the original function.

answered Mar 28, 2012 at 3:07

Ry-♦

226k56 gold badges496 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

cwd Over a year ago

not a method to edit the attribute but a slick way to achieve what i wanted. thanks so much! +1

Simon Wang · Accepted Answer · 2012-03-28 03:05:33Z

0

use $(this).unbind() to clear handlers on that element and then add new one

answered Mar 28, 2012 at 3:05

Simon Wang

3,0131 gold badge19 silver badges37 bronze badges

Comments

jcreamer898 · Accepted Answer · 2012-03-28 03:09:57Z

0

As of jQuery 1.7, this should work...

jQuery('a').each(function(){
    $(this).off('click')
        .on('click', do_delete_image);
});

answered Mar 28, 2012 at 3:09

jcreamer898

8,1895 gold badges44 silver badges58 bronze badges

Collectives™ on Stack Overflow

How can I replace the onclick action (with regex) using javascript / jQuery?

Sample HTML

My Attempt

Error

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Sample HTML

My Attempt

Error

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related