Shell script doesn't properly execute from ruby CGI script

Question

I've got a ruby cgi script which calls a shell script.

The shell script does a git pull.

When I run the shell script from the command prompt it works.

But when I run it from the ruby cgi script it executes the script but the git pull doesn't happen.

I'm guessing it's possibly permissions related but I can't quite work out how to fix it.

The ruby script is:

#!/usr/local/rvm/rubies/ruby-1.9.3-p125/bin/ruby
require "cgi"
git_pull = `sh /github/do_git_pull.sh`
move_apanels = `sh /github/move_apanels.sh`

puts "Content-type: text/html\n\n"
puts "<html><body>We've done the following:<ul>"
puts "<li>#{git_pull.to_s}</li>"
puts "<li>#{move_apanels.to_s}</li>"
puts "</ul></body></html>"

And the shell script is:

#!/bin/bash
sudo sh -c cd /github
sudo sh -c git pull origin master
echo "Git Pull Completed"

Both files have chmod 777

Any ideas?

glenn jackman · Accepted Answer · 2012-03-29 13:37:14Z

2

Doing this:

sudo sh -c cd /github

only changes the PWD for the duration of that sh command. It does not affect the current shell. You need to cd and git pull in the same subshell:

sudo sh -c 'cd /github && git pull origin master'

answered Mar 29, 2012 at 13:37

glenn jackman

249k42 gold badges233 silver badges362 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-04-13 12:13:40Z

-1

Setting 777 on your scripts won't cut it. Try and find out the user under which your ruby script executes the shell script. Since git uses SSH keys for authentication and normally your SSH keys can only be used by you, then git pull would fail if another user tries to do the git pull.

Check out this question on how to run a shell script as a different user.

Also make sure that the PATH in the target environment is set properly and accessible (if you run the web server chrooted).

edited Apr 13, 2017 at 12:13

CommunityBot

11 silver badge

answered Mar 29, 2012 at 12:43

Kibet Yegon

2,8332 gold badges27 silver badges32 bronze badges

Collectives™ on Stack Overflow

Shell script doesn't properly execute from ruby CGI script

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related