Java -for loop only repeating last value

Question

I have an Array to hold the value from DB. If I try with some default data it working fine but if I get value from DB, its only showing last value.

Default Data;

MenuList menu_data [] = new MenuList[]{};
menu_data  = new MenuList[]
{
new MenuList("test","test1") ,      
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") ,  
new MenuList("test","test1") 
};

Value from DB,

MenuList menu_data [] = new MenuList[]{};
List<Menu> profiles = db.getAllContacts();
for (Menu cn : profiles) {
menu_data  = new MenuList[]
{
new MenuList(cn.getmenuname(), cn.getmenuprice())  
};
}

How do I get all the value from DB.

in my profiles I have few values like menu,price,Vege,Time,Date...I just want to show menu and price.... — chinna_82
– chinna_82, Commented Mar 30, 2012 at 3:30

Chetter Hummin · Accepted Answer · 2012-03-30 03:29:08Z

3

Everytime you go through the loop, you are creating a new array. Hence, only the last value is available. Please try the following

menu_data  = new MenuList[profiles.size()];

for (int i = 0; i < menu_data.length; i++) {
    Menu cn = profiles.get(i);
    menu_data[i] = new MenuList(cn.getmenuname(), cn.getmenuprice());  
}

answered Mar 30, 2012 at 3:29

Chetter Hummin

6,8478 gold badges34 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Luiggi Mendoza Over a year ago

you need to declare and initialize i variable: int i = 0; and in the loop: ` menu_data[i++] = ...`

Chetter Hummin Over a year ago

@LuiggiMendoza Missed that completely! Thanks

chinna_82 Over a year ago

it throw java.lang.ArrayIndexOutOfBoundsException: length=0; index=0

Chetter Hummin Over a year ago

@chinna_82 Which line is the exception thrown at?

Óscar López · Accepted Answer · 2012-03-30 03:40:25Z

2

Try this:

List<MenuList> menulists = new ArrayList<MenuList>();
for (Menu cn : db.getAllContacts())
    menulists.add(new MenuList(cn.getmenuname(), cn.getmenuprice()));
MenuList[] menu_data = menulists.toArray(new MenuList[0]);

edited Mar 30, 2012 at 3:40

answered Mar 30, 2012 at 3:32

Óscar López

237k38 gold badges321 silver badges391 bronze badges

Comments

Jon Newmuis · Accepted Answer · 2012-03-30 04:43:57Z

2

List<Menu> profiles = db.getAllContacts();
int numProfiles = profiles.size();
MenuList[] menu_data = new MenuList[numProfiles];
for (int i = 0; i < numProfiles; i++) {
    Menu cn = profiles.get(i);
    menu_data[i] = new MenuList(cn.getmenuname(), cn.getmenuprice());
}

edited Mar 30, 2012 at 4:43

answered Mar 30, 2012 at 3:31

Jon Newmuis

26.7k3 gold badges48 silver badges57 bronze badges

2 Comments

chinna_82 Over a year ago

it throw 2 error.. 1st. Cannot define dimension expressions when an array initializer is provided..2nd java.lang.ArrayIndexOutOfBoundsException: length=0; index=0

Jon Newmuis Over a year ago

Sorry, I meant to just create it instead of using the initializer. Fixed. If length = 0 then the for loop body will not be executed at all.

Collectives™ on Stack Overflow

Java -for loop only repeating last value

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related