PHP Class variable question

Question

I have the following class which handles my user logged in / logged out (I only included what's relevant here). I want to redirect users who are logged in who visit login.php to there account page. I do this using....

    $User = new User();
if ($User->loggedin = 'true') header('Location:MyAccountNEW.php');

The issue is this redirects to myaccountnew.php weather I switch it to true or false.. (although it does not when the condition is (2>3). Aslo when I echo $User-loggedin, nothing comes up. I'm kinda stumped...

Heres the class

Class User {

public $loggedin = false;
public $username = "";
public $ShopperID = "";

function __construct() {
    $this->CheckLogin();
}

function CheckLogin() {
    if (!empty($_SESSION['LoggedIn']) && !empty($_SESSION['Username'])) {
            $this->loggedin = true;
            $this->username = $_SESSION['Username'];
    }
    else {
        $this->loggedin = false;
    }
}

heres what logout.php looks like

<?php include ("base.php");
  include("userclass.php");

  $User = new User();
  $User->loggedin = false;

$_SESSION = array(); session_destroy(); ?>

Christ, I cannot believe I missed an extra equals sign lol. Thanks ;) — user117399
– user117399, Commented Jun 15, 2009 at 4:04

nickf · Accepted Answer · 2009-06-15 04:07:47Z

6

You're using a single equals (=) instead of two (==)

Also, I would strongly recommend adding this:

if ($User->loggedIn == 'true') {
    header('location: somewhereelse.php');
    die(); // <-- important!!
}

Also, since that property is a boolean, you should be comparing against the actual bool value true instead of the string "true".

if ($User->loggedIn == true)

// or even shorter:

if ($User->loggedIn)

this is because:

true == "true"
true == "foo"
true == "false"

Any string value apart from an empty string or the string "0" is considered true.

edited Jun 15, 2009 at 4:07

answered Jun 15, 2009 at 3:59

nickf

548k199 gold badges660 silver badges727 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jonathan Fingland Over a year ago

excellent point about adding die() to prevent continued processing of the page

Galen · Accepted Answer · 2012-05-19 19:35:01Z

1

replace

if ($User->loggedin = 'true')

with

if ($User->loggedin == 'true')

because

if ($User->loggedin = 'true')

is an assignment and will always return true

probably just a typ0 of yours =]

edited May 19, 2012 at 19:35

answered Jun 15, 2009 at 3:59

Galen

30.2k9 gold badges75 silver badges90 bronze badges

Collectives™ on Stack Overflow

PHP Class variable question

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related