Detecting a click on a tile

Question

I'm making a simple tile-map system in LWJGL, and I'm trying to figure out how to detect if the mouse is clicking inside of a tile. So far no matter where I click it's always the same tile that is shown.

Code:

int blockWidth = 100;
int blockHeight = 100;

List<Tile> tiles = new ArrayList<Tile>();

private void addTiles(){
    for(int i = 0; i < ((Display.getHeight() / blockHeight) * (Display.getWidth() / blockWidth)); i++)
        tiles.add(new Tile(10,10,blockWidth,blockHeight, i));
}

//...

if(Mouse.isButtonDown(0)){
            System.out.println("Mouse clicked at (" + Mouse.getX() + ", " + Mouse.getY() + ")");
            for(Tile tile : tiles){
                if(tile.inBounds(Mouse.getX(), Mouse.getY())){
                    tile.highlight();
                    System.out.println("Box clicked at (" + Mouse.getX() + ", " + Mouse.getY() + ").");
                    break;
                }
            }
}

the inBounds method:

public boolean inBounds(int x, int y){
    Rectangle bounds = new Rectangle();
    bounds.setBounds(x, y, width, height);
    if(bounds.intersects(x,y,1,1)){
        System.out.println("Tile " + num + " clicked. X/Y val is (" + this.x + "," + this.y + ")");
        return true;
    }else{
        return false;
    }

}

Luis Estrada · Accepted Answer · 2012-02-29 00:23:41Z

3

The x and y you use here:

bounds.setBounds(x, y, width, height);

are the parameters x, y that are being passed into the method.

I am assuming that there is also an x and y in your Tile class. So you either need to rename the parameters or use this. in front of your variables.

public boolean inBounds(int x, int y){
    Rectangle bounds = new Rectangle();
    bounds.setBounds(this.x, this.y, width, height); // change here
    if(bounds.intersects(x,y,1,1)){
        System.out.println("Tile " + num + " clicked. X/Y val is (" + this.x + "," + this.y + ")");
        return true;
    }else{
        return false;
    }
}

answered Feb 29, 2012 at 0:23

Luis Estrada

1,6321 gold badge11 silver badges14 bronze badges

\$\begingroup\$ "this" is very tricky! A very common mistake. One that I am prone to as well even after as many years as I have been coding. The primary way I use to combat this problem (usually quite effectively), is to always have "the" in front of parameters passed to a function. For example, if I were to write inBounds, the parameter names would be theX and theY. Helps me anyway. Might help others as well to have a naming convention to help avoid this all too common issue. \$\endgroup\$

PlayDeezGames
– PlayDeezGames

2012-02-29 01:35:49 +00:00
Commented Feb 29, 2012 at 1:35
\$\begingroup\$ @PlayDeezGames - I've gotten into the habit of naming all my class fields starting with an underscore (_). I've also seen the use of m_ for fields (the "m" stands for "member" because, as you can see in the docs, fields implement the Member interface). Personally, I don't really like the m_ but regardless, naming and scope are very important when programming. :) \$\endgroup\$

Richard Marskell - Drackir
– Richard Marskell - Drackir

2012-02-29 03:18:35 +00:00
Commented Feb 29, 2012 at 3:18

Add a comment |

Functastic · Accepted Answer · 2012-02-29 12:15:16Z

4

You can avoid the potentially O(N*M) containemt checks by simply calculating the tile's array index in O(1) time:

int pixelCoordToIndex(int x, int y)
{
    return ((y / tileHeight) * numTilesX) + (x / tileWidth);
}

Your code is then reduced to:

System.out.println("Tile " + pixelCoordToIndex(x, y) + " clicked. X/Y val is (" + x + "," + y + ")");

This decouples the performance of containment checks from the map's extents, saving millions of unnecessary checks on moderately large maps.

edited Feb 29, 2012 at 12:15

answered Feb 29, 2012 at 2:01

Functastic

2242 silver badges4 bronze badges

Add a comment |

Stack Exchange Network

Detecting a click on a tile

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Detecting a click on a tile

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions