how to write javascript function as string in php?

Question

I have one line in php file like this:

<a class="hide-if-no-js" onclick="findPosts.open( 'media[]','<?php echo $post->ID ?>' ); return false;" href="#the-list">Attach</a>

I need to write this line as a string in a php function, I tried this:

$output .="<a class='hide-if-no-js' onclick='findPosts.open( 'media[]','$id' ); return false;' href='#the-list'>'$linktext'</a>";

Seems the quote around 'media[]' is wrong and made the html of this line messed up. Could anybody help correct me?

If you need to output this, why don't you output it directly outside the PHP script? — Alvin Wong
– Alvin Wong, Commented Jun 20, 2012 at 2:21

xdazz · Accepted Answer · 2012-06-20 02:28:26Z

2

$output .= "<a class=\"hide-if-no-js\" onclick=\"findPosts.open( 'media[]','$id' ); return false;\" href=\"#the-list\">$linktext</a>";

Your javascript string use single quote, so the html attribute should use double quote.

edited Jun 20, 2012 at 2:28

answered Jun 20, 2012 at 2:15

xdazz

161k38 gold badges255 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Jared Farrish Over a year ago

You could also use a HEREDOC or an output buffer to avoided having to use escaped quotes, although in this case either the attribute quotes or the embedded Javascript quotes would need to be reversed.

Jared Farrish Over a year ago

Also, are you saying HTML attributes are required by spec to use "?

Fabrício Matté Over a year ago

As per the RFC, either double quotes or single quotes can be used for HTML attributes.

Jared Farrish Over a year ago

In XHTML. There's no indication that's the case here, and if you make a comment like that, it needs to be specific. That's how people get the idea it's required but can't remember why. And hey, y'know, I prefer double-quotes, but it's not factually correct by omission.

Jared Farrish Over a year ago

@Jenny - I meant you have two considerations for escaping quotes using double-quoted strings in your PHP; the others you only have one, but that case still exists in your html because you can't have the same quotes for attributes and within attribute values. So you would still have to reverse one set. Nothing to do with any JS function.

|

Marcio Mazzucato · Accepted Answer · 2012-06-20 02:24:58Z

1

You can try:

$output .= '<a class="hide-if-no-js" onclick="findPosts.open( \'media[]\',\'' . $id . '\' ); return false;" href="#the-list">' . $linktext . '</a>';

OR

$output .= "<a class='hide-if-no-js' onclick='findPosts.open( \"media[]\", \"$id\" ); return false;' href='#the-list'>$linktext</a>";

edited Jun 20, 2012 at 2:24

answered Jun 20, 2012 at 2:18

Marcio Mazzucato

9,36511 gold badges71 silver badges82 bronze badges

4 Comments

Jared Farrish Over a year ago

Note there is a PHP variable in there that needs expansion using ".

Marcio Mazzucato Over a year ago

@JaredFarrish, Note that the variables are concatened with the string, so it will be returned normally

Jared Farrish Over a year ago

The original, non-recorded response didn't have the concatenation. And then you edited it initially and fixed it. I'm not blind.

Marcio Mazzucato Over a year ago

@JaredFarrish, Maybe i forgot, anyway, thanks for your comment!

Collectives™ on Stack Overflow

how to write javascript function as string in php?

2 Answers 2

8 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related