Displaying multiple rows in PHP array

Question

I have a script I wrote to return records for cases out of the database. I am returning one record for my mysql query when there are actually two records. This is what I am returning:

{ "cases": [ {"name":"Test Case for App","number":"3846"}] }

I should see:

{ "cases": [ {"name":"Test Case for App","number": "2903"}, {"name":"Test Case 2","number": "2856"} ] }

Here is my source:

$sql = "select * from cases as c join contacts_cases as conc on c.id = conc.case_id where conc.contact_id = '1b360507'";
$query = mysql_query($sql);  

// If we find a match, create an array of data, json_encode it and echo it out  
if (mysql_num_rows($query) > 0)  
{  
    $row = mysql_fetch_assoc($query);  
    $response = array(  
        'name' => $row['name'],  
        'number' => $row['case_number']
    );  

    echo '{ "cases": [ ',  json_encode($response), "] }";

You might want to use a loop there to grab all the values.

inhan
– inhan

2012-07-12 17:34:51 +00:00
Commented Jul 12, 2012 at 17:34 — inhan
– inhan, Commented Jul 12, 2012 at 17:34

Aaron W. · Accepted Answer · 2012-07-12 17:38:07Z

6

If you are expecting more than one result you should try

if (mysql_num_rows($query) > 0)  
{  
    $responses = array();
    while($row = mysql_fetch_assoc($query)) {
        $responses[] = array(  
            'name' => $row['name'],  
            'number' => $row['case_number']
        );  
    }
    echo '{"cases": ' . json_encode($responses) . '}';
}

edited Jul 12, 2012 at 17:38

answered Jul 12, 2012 at 17:32

Aaron W.

9,2952 gold badges36 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hakre · Accepted Answer · 2012-07-12 17:44:51Z

2

You need to loop through all the rows, you're just getting one.

Also, don't try to build the JSON yourself. Make the array how you want then json_encode the entire thing.

$cases = array();
while ($row = mysql_fetch_assoc($query)) {
    $cases[] = array(  
        'name'   => $row['name'],  
        'number' => $row['case_number']
    );
}

echo json_encode(array('cases' => $cases));

edited Jul 12, 2012 at 17:44

hakre

200k55 gold badges453 silver badges865 bronze badges

answered Jul 12, 2012 at 17:42

gen_Eric

228k42 gold badges304 silver badges343 bronze badges

1 Comment

gen_Eric Over a year ago

@hakre: Thanks for cleaning my code. I'm starting to run out of caffeine.

Collectives™ on Stack Overflow

Displaying multiple rows in PHP array

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related