Html src = a php variable

Question

Hello I looked around a bit for a solution but couldn't find someone with the exact problem as me. Basically I have a php variable that is a url. I want to add a new iframe with that url.

This is what I have, but because HTML is using the double quotes after src the php variable is ignored.

<iframe width="420" height="345"src= "<?php $output ?>"> </iframe>

Thank you guys

Answers below (you forgot the echo), but just saying that HTML can also use single quotes. — Mr Lister
– Mr Lister, Commented Mar 10, 2014 at 19:37

Brad · Accepted Answer · 2014-03-10 19:30:47Z

5

<iframe width="420" height="345" src="<?php echo htmlspecialchars($output); ?>"> </iframe>

You're missing echo. Also, always use htmlspecialchars() to ensure you are creating valid HTML that isn't vulnerable to injection. If you find yourself doing this a lot, consider using a template engine.

answered Mar 10, 2014 at 19:30

Brad

164k57 gold badges380 silver badges559 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user3369289 Over a year ago

Thank you very much! Worked wonderfully. Most of the work that I have done in the past has all been offline games and such. Haven't done much with online work. I was unfamiliar with htmlspecialchars. What exactly does that do?

PointedEars Over a year ago

@Brad Since PHP 5.4, <?php echo can be safely replaced with <?=. Previous versions required short_open_tag or asp_tags to be on; the former caused problems with XML, but with the latter you could use <%= instead.

Brad Over a year ago

@user3369289 It will take characters like < and > and convert them to < and > to make sure they aren't interpreted as HTML. You don't want text content to leak to your HTML. In worse cases, if you are outputting text from users, it might contain <script> tags.

user3369289 Over a year ago

Interesting I will look into this! Thanks again

Sammitch · Accepted Answer · 2014-03-10 19:34:57Z

0

<iframe width="420" height="345" src="<?php echo htmlspecialchars($output); ?>"> </iframe>

edited Mar 10, 2014 at 19:34

Sammitch

32.5k7 gold badges58 silver badges92 bronze badges

answered Mar 10, 2014 at 19:33

Mubin

4,4655 gold badges37 silver badges56 bronze badges

Collectives™ on Stack Overflow

Html src = a php variable

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related