Simplify PHP code and Regex

Question

I could use some help simplifying the following code that includes a regex statement. I am simply trying to get the integers from all possible substrings contained in a larger text and then push those integers onto an array. I know I should not have to use split, but I forget how to do do it with regex.

    preg_match_all('/bar:foo\(?[0-9]*\);/', $in , $tag);
    for ($i = 0; $i < count($tag[0]); $i++) {
        $parts = explode("(", $tag[0][$i]);           
        $parts2 = explode(")", $parts[1]);
        array_push($myArr, $parts2[0]);
    }

hakre · Accepted Answer · 2012-04-17 12:25:58Z

3

Actually, you might not need to use preg_split, but you can already improve it by modifying your current pattern:

$numbers = preg_match_all('/bar:foo\(?([0-9]*)\);/', $in , $matches) 
           ? array_map('intval', $matches[1])
           : array();

answered Apr 17, 2012 at 12:25

hakre

200k55 gold badges454 silver badges865 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

safarov · Accepted Answer · 2012-04-17 12:25:31Z

1

preg_match_all('/bar:foo\(?([0-9]*)\);/', $in , $tags);
print_r($tags);

answered Apr 17, 2012 at 12:25

safarov

7,7942 gold badges38 silver badges52 bronze badges

Collectives™ on Stack Overflow

Simplify PHP code and Regex

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related