How to call object methods for an object in an array using a foreach loop

Question

I am trying to store a collection of objects and can't call object methods in a foreach loop. This is basically what I have. The print function prints nothing. Is there something I am over looking or is this not the way to go about it?

class person
{
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function get_name() {
        return $this->name;
    }
}

$test_set[] = new person("John");
$test_set[] = new person("Jane");

foreach($test_set as $set_item) {
    print $set_item->get_name();
}

I copy-pasted your code and it works fine. The problem is somewhere else. Do you have error reporting turned on? — Manos Dilaverakis
– Manos Dilaverakis, Commented Apr 25, 2012 at 20:08
This is a simplified version of my code. I copy pasted it, and it worked too. It must be something in my more advanced class. — wachpwnski
– wachpwnski, Commented Apr 25, 2012 at 20:14
Try this code. It might be the multiple parameter construct? gist.github.com/a7e525e84cb95057a676 — wachpwnski
– wachpwnski, Commented Apr 25, 2012 at 20:23

dan-lee · Accepted Answer · 2012-04-25 20:01:11Z

3

You need to set your name like this (probably just a typo):

public function __construct($name) {
    $this->name = $name; // not $this->$name
}

answered Apr 25, 2012 at 20:01

dan-lee

14.5k6 gold badges55 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

wachpwnski Over a year ago

That was a typo on here. It still does not change the blank output.

dan-lee Over a year ago

Well for me it works in a test file. Any error output with error_reporting(E_ALL); ini_set('display_errors', '1'); at the top?

wachpwnski Over a year ago

@DanLee I did set both of those, and everything is good. It is just printing nothing.

dan-lee Over a year ago

Try it with echo then? I can't explain this behaviour. Or you need to give us more of the code.

Skrol29 · Accepted Answer · 2012-04-25 20:05:34Z

2

Your loop is working. But your class contains a mistake.

Replace:

    public function __construct($name) {
        $this->$name = $name;
    }

With:

    public function __construct($name) {
        $this->name = $name;
    }

answered Apr 25, 2012 at 20:05

Skrol29

5,6031 gold badge23 silver badges27 bronze badges

1 Comment

Mike Purcell Over a year ago

Ugh @ anonymous down-votes. Maybe because the downvoter thought it came several minutes later than a very similar answer. But is still correct.

Collectives™ on Stack Overflow

How to call object methods for an object in an array using a foreach loop

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related