Trying to call object methods in array

Question

Im learning php and i made this simple class for creating form.

class form {

private $pole= array();

function addText($name, $label){

    $pole[] = new input($name, 'text', $name, $label);
}

function create(){
    foreach ($this->pole as $polozka) {
        $polozka->addInput();
    }
}
}

class input{

private $name;
private $type;
private $id;
private $label;

/*
 * $name, $type, $id, $label
 */
function __construct($name, $type, $id, $label){
    $this->name=$name;
    $this->type=$type;
    $this->id=$id;
    $this->label=$label;
}

function addInput(){
    echo "<label for='".$this->name.": '>".$this->label."<input type='".$this->type."' name='".$this->name."' id='".$this->id."'/>";
}

}

And then Im calling it like this

<?php include "form.php";

$form = new form();
$form->addText('jmeno', 'Jméno');
$form->addText('prijmeni', 'Příjmení');
$form->create();
?>

but it does absolutely nothing. :( Dont you know whats wrong with it?

I think the problem may be with calling the object in array or saving them to array. Im used to do it like that from java. but yes, its a but different.

Mark Baker · Accepted Answer · 2013-11-06 18:16:44Z

2

function addText($name, $label){

    $this->pole[] = new input($name, 'text', $name, $label);
}

not

function addText($name, $label){

    $pole[] = new input($name, 'text', $name, $label);
}

You should probably also add a visibility of public to the methods in your classes... while they'll default to public anyway unless defined otherwise, an explicitly defined visibility does make it immediately obvious

answered Nov 6, 2013 at 18:16

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2202284 Over a year ago

Thank you very much guys!! I was looking for the mistake nearly 20 minutes and I didnt see it.

SamA · Accepted Answer · 2013-11-06 18:16:45Z

1

You are not referring to your class member:

function addText($name, $label){
    $pole[] = new input($name, 'text', $name, $label);
}

Should be:

function addText($name, $label){
    $this->pole[] = new input($name, 'text', $name, $label);
}

answered Nov 6, 2013 at 18:16

SamA

5873 silver badges6 bronze badges

1 Comment

user2202284 Over a year ago

Thank you very much guys!! I was looking for the mistake nearly 20 minutes and I didnt see it.

Collectives™ on Stack Overflow

Trying to call object methods in array

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related