if... else if javascript

Question

I am doing a form validation and having troubles with my code:

var reValue = /^\s*$/;      
var phoneClass = /(^|\s)phoneValidate(\s|$)/;              
var phoneValue = 
     /^[01]?[- .]?(\([2-9]\d{2}\)|[2-9]\d{2})[- .]?\d{3}[- .]?\d{4}$/;  

for (var i=0; i < iLen; i++) {
    el = allElements[i];

    if(phoneClass.test(el.className) && reValue.test(el.value)){
        // The field is empty.
        aMessages += 'Please enter a phone number in: '+ el.name +'.\n';
    }
    else if (phoneClass.test(el.className) && phoneValue.test(el.value)) {
        // The field is not a valid phone number
        // Advise user to fix it
        aMessages += 'Please enter a valid phone number in: '+ el.name +'.\n';
    }
}

The first IF statement works and displays the massage if the field is empty, but the ELSE IF for some reason does not... What am I doing wrong?

You just need to massage your code a bit (sorry about that, couldn't resist!) — bfavaretto
– bfavaretto, Commented May 16, 2012 at 20:12
@DavidWolever How does that comment even suit in this case...? The OP has created a SSCE, and phrased a clear question. What else can he do before posting the question? — Rob W
– Rob W, Commented May 16, 2012 at 20:15
@RobW you are right. Radi, please forgive me for taking out my unrelated frustrations on StackOverflow. — David Wolever
– David Wolever, Commented May 18, 2012 at 4:54

jfriend00 · Accepted Answer · 2012-05-16 20:14:37Z

2

Based on looking at your regex, I think you need to invert the logic on the phoneValue test. You want the else if clause to execute when it does NOT match the phoneValue regex like this:

else if (phoneClass.test(el.className) && !phoneValue.test(el.value)) {

answered May 16, 2012 at 20:14

jfriend00

711k104 gold badges1.1k silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Radi Over a year ago

Thank you very much for your help! I have been banging my head against the wall for the past 2-3 hours not knowing what is going on... Thanks a lot!

PRNDL Development Studios · Accepted Answer · 2012-05-16 20:13:12Z

1

phoneValue.test(el.value) resolves to false. That is why the else if is not firing.

answered May 16, 2012 at 20:13

PRNDL Development Studios

3,3102 gold badges37 silver badges51 bronze badges

Collectives™ on Stack Overflow

if... else if javascript

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related