Convert csh script to bash script

Question

I am currently converting a csh script on linux to a bash script on Mac OS X lion.

The csh script looks like:

setenv CNS_SOLVE '/Users/ucbthsa/Documents/haddock2.1/software/bin/'
setenv CNS_SOLVE $CNS_SOLVE
if ( -d $CNS_SOLVE ) then
    if ( ! $?CNS_ARCH ) setenv CNS_ARCH `$CNS_SOLVE/bin/getarch`
else
    setenv CNS_ARCH 'unknown'
endif

My conversion to a Mac bash script looks as follows:

export CNS_SOLVE='/Users/ucbthsa/Documents/haddock2.1/software/bin/cns_solve_1.3'
export CNS_SOLVE=$CNS_SOLVE

if [ -d $CNS_SOLVE ]; then
  if [ ! $?CNS_ARCH ]; then
    export CNS_ARCH='$CNS_SOLVE/bin/getarch'
else
  export CNS_ARCH='unknown'
endif

When I try and source the Mac bash script I get the following error:

-bash: cns_solve_env: line 10: syntax error: unexpected end of file

I cannot understand why I am getting this error.

"fi" instead of "endif"?

SignalToNoise
– SignalToNoise

2012-06-07 14:33:26 +00:00
Commented Jun 7, 2012 at 14:33 — SignalToNoise
– SignalToNoise, Commented Jun 7, 2012 at 14:33
Oh and there's also the second if that's not closed

SignalToNoise
– SignalToNoise

2012-06-07 14:36:52 +00:00
Commented Jun 7, 2012 at 14:36 — SignalToNoise
– SignalToNoise, Commented Jun 7, 2012 at 14:36

John Lawrence · Accepted Answer · 2012-06-07 15:29:00Z

3

You should use fi rather than endif and you aren't closing the first if at all:

export CNS_SOLVE='/Users/ucbthsa/Documents/haddock2.1/software/bin/cns_solve_1.3'
export CNS_SOLVE=$CNS_SOLVE

if [ -d $CNS_SOLVE ]; then
  if [ -z $CNS_ARCH ]; then
    export CNS_ARCH="$CNS_SOLVE/bin/getarch"
  fi
else
  export CNS_ARCH='unknown'
fi

*edit: changed the second test, as William Pursell pointed out, it wouldn't work as it was in bash.

edited Jun 7, 2012 at 15:29

answered Jun 7, 2012 at 14:33

John Lawrence

2,92319 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

William Pursell Over a year ago

! $?CNS_ARCH will always evaluate false, since the string being tested will always be XCNS_ARCH where X is the value of $?.

Gordon Davisson Over a year ago

You should double-quote when you expand variables: [ -d "$CNS_SOLVE" ] and especially [ -z "$CNS_ARCH" ] to avoid parsing confusion. Also, single-quotes prevent variable expansion, so use export CNS_ARCH="$CNS_SOLVE/bin/getarch"

William Pursell · Accepted Answer · 2012-06-07 14:40:51Z

0

$?CNS_ARCH means something different in sh. Use:

test -z "$CNS_ARCH" && CNS_ARCH=$($CNS_SOLVE/bin/getarch)

or

CNS_ARCH=${CNS_ARCH-$( $CNS_SOLVE/bin/getarch)}

Notice that these have slightly different meanings. The first is will assign to CNS_ARCH if CNS_ARCH is already set but is the empty string, while the second will not change CNS_ARCH if it is already set, but is empty, which is what the $? does in csh, but is probably not what you actually want.

edited Jun 7, 2012 at 14:40

answered Jun 7, 2012 at 14:35

William Pursell

214k49 gold badges279 silver badges317 bronze badges

Collectives™ on Stack Overflow

Convert csh script to bash script

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related