How to execute .csh script with command line arguments from .csh script

Question

So I have .csh script generate.csh I want to call another .csh script from within it. I tried

./shell_gen.csh test1 test2.prt

But it runs shell_gen.csh but without command line arguments.

Anyone?

Thanks

generate.csh

#!/bin/csh
./shell_gen.csh test1 test2.prt

shell_gen.csh

#!/bin/csh
set source = output
############################################################
# create pbm-gifs/ directory
############################################################
set destination1 = /scratch/graphics/$1gif
echo making $destination1

if ( ! -e $destination1 ) then
  mkdir $destination1
  foreach file ( $source/*.pgm )
    echo convert $file $destination1/$file:t:r.gif
    convert $file $destination1/$file:t:r.gif
end
else
echo "$destination1/ exists"
endif

So shell_gen.csh echoes "making /scratch/graphics/gif" (i.e. nothing between "/" and "gif")? Your script works for me (it echoes "making /scratch/graphics/test1gif"). — Dennis Williamson
– Dennis Williamson, Commented Sep 18, 2009 at 0:59

Dennis Williamson · Accepted Answer · 2009-09-17 21:08:46Z

2

I would say you probably need to put curly braces around the positional parameter variable when they are concatenated against some other characters:

set destination1 = /scratch/graphics/${1}gif

But you might want a dot in there, too:

set destination1 = "/scratch/graphics/${1}.gif"

and quotes protect against spaces.

edited Sep 17, 2009 at 21:08

answered Sep 17, 2009 at 20:55

Dennis Williamson

364k95 gold badges386 silver badges446 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

grobartn Over a year ago

that part works.... when I run from command line the script ./shell_gen.csh test test1.prt it works fine...when its called from script above it doesnt work

pbr · Accepted Answer · 2009-09-25 21:40:17Z

1

$1gif isn't a reference to a positional parameter.

Did you try ${1}gif as Dennis suggested? I think that should work.

ALSO I see no reference to $2 anywhere though your generate clearly sends a second argument.

Lastly the first line should probably be #!/bin/csh -f

Best,
-pbr

answered Sep 25, 2009 at 21:40

pbr

4803 silver badges8 bronze badges

Collectives™ on Stack Overflow

How to execute .csh script with command line arguments from .csh script

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related