Python: If in a For Loop

Question

I'm creating a list of files with coordinates and id numbers.
a is just an arbitrary value to space out points. f is a file opened earlier and closed later. I'm using the code listed below. It should generate 511 points, skipping one point that would've originally been the 293rd point. Instead it is skipping 169 points and I cannot figure out why. Any help on this would be greatly appreciated.

id=1

for i in range(0,8,1):
    for j in range(0,8,1):
        for k in range(0,8,1):
            x1=i*a
            y1=j*a
            z1=k*a
            if ((i!=4) & (j!=4) & (k!=4)):
                f.write("%4.d  1  4  %4.3f  %4.3f  %4.3f\n"%(id, x1, y1, z1))
                id=id+1

@David -- so is f -- You can guess what they are.

mgilson
– mgilson

2012-06-13 17:36:11 +00:00
Commented Jun 13, 2012 at 17:36 — mgilson
– mgilson, Commented Jun 13, 2012 at 17:36

Sven Marnach · Accepted Answer · 2012-06-13 18:16:07Z

5

Since you require that i must be different from 4 AND j must be different from 4 AND k must be different from 4, you are skipping all points where ANY of these is 4. Use

if i != 4 or j != 4 or k != 4:

instead. Equivalently, but probably easier to grasp, you could write

if not (i == 4 and j == 4 and k == 4):

or even better

if i, j, k != 4, 4, 4:

Edit: Here's a completely rewritten version of your code:

points = itertools.product(range(0, 8 * a, a), repeat=3)
points = (p for p in points if p != (4 * a, 4 * a, 4 * a))
with open("filename", "w") as f:
    for id_p in enumerate(points, 1):
        f.write("%4.d  1  4  %4.3f  %4.3f  %4.3f\n" % id_p)

edited Jun 13, 2012 at 18:16

answered Jun 13, 2012 at 17:36

Sven Marnach

608k123 gold badges966 silver badges865 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pavel Strakhov · Accepted Answer · 2012-06-13 18:41:14Z

0

Your condition is wrong, there should be 'or' instead of 'and'. Also, your code can be simplified a bit, it should look like this:

for i in range(8):
    for j in range(8):
        for k in range(8):
            x1 = i * a
            y1 = j * a
            z1 = k * a
            if i != 4 or j != 4 or k != 4:
                print("%4.d  1  4  %4.3f  %4.3f  %4.3f\n" % (id, x1, y1, z1))
                id += 1

edited Jun 13, 2012 at 18:41

answered Jun 13, 2012 at 17:40

Pavel Strakhov

40.8k6 gold badges93 silver badges131 bronze badges

1 Comment

mgilson Over a year ago

can simplify a little more: range(0,8) -> range(8)

Collectives™ on Stack Overflow

Python: If in a For Loop

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related