retrieving record from database using cursor in android

Question

I have used following codes to retrieve record:

String getCredentialsFromAdmint(String name ,String pwd) {
        SQLiteDatabase db = this.getReadableDatabase();

        Cursor cursor = db.query(TABLE_ADMIN, new String[] { KEY_ID,
                KEY_A_USER_NAME, KEY_A_PWD }, KEY_A_USER_NAME + "=?" + " AND " + KEY_A_PWD + "=?",
                new String[] { name , pwd }, null, null, null, null);

        if (cursor != null){
            cursor.moveToFirst();
        return cursor.getString(1);
        }
        else{
            return "norecord";
        }

This code works if there is a record but if no record is found then application gets an error. Is there any other ways to retrieve data from database?

Waqas · Accepted Answer · 2012-07-03 12:14:32Z

1

Change your code to following

 if ( cursor.moveToFirst()){
      return cursor.getString(1);
    } else{
        return "norecord";
    }

answered Jul 3, 2012 at 12:14

Waqas

4,5196 gold badges29 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Leszek · Accepted Answer · 2012-07-03 12:14:03Z

0

You don't check if cursor.moveToFirst() returns true;

It should looks like this:

if (cursor != null) {
   if(cursor.moveToFirst()){
       return cursor.getString(cursor.getColumnIndexOrThrow(KEY_A_USER_NAME));
   } else{
     //no record
   }
} else {
   //invalid uri
}

answered Jul 3, 2012 at 12:14

Leszek

6,5983 gold badges44 silver badges54 bronze badges

Comments

Umar Qureshi · Accepted Answer · 2012-07-03 12:14:03Z

0

Try to use the following code instead

if (cursor != null){
    cursor.moveToFirst();
    if(cursor.isAfterLast() == false) {
    return cursor.getString(1);
    }
    else
    {
    return "norecord";
    }
}
else{
    return "norecord";
}

answered Jul 3, 2012 at 12:14

Umar Qureshi

6,1252 gold badges33 silver badges40 bronze badges

Collectives™ on Stack Overflow

retrieving record from database using cursor in android

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related