Javascript string parameter in function

Question

I'm working with google maps api and I want the label of a marker have a link that execute a warning.

var str = "hi";
var mp_position = createGoogleMapsLocation(data[i].location);
var text = "<p>Edit: <a href=# onClick='edit("+str+")'>Click here</a></p>";
addMeetingMarker(mp_position, text);

The addMeetingMarker function works, but edit function not. The code is:

function edit(message) {
    alert(message);
}

If you set an integer in the argument of the edit function it works, but passing the variable str does not work. Why?

BlackSpy · Accepted Answer · 2012-07-05 20:10:42Z

6

You need more double quotes to surround your value string - so:

var text = "<p>Edit: <a href=# onClick='edit("+str+")'>Click here</a></p>";

becomes

var text = "<p>Edit: <a href=# onClick='edit(\""+str+"\")'>Click here</a></p>";

answered Jul 5, 2012 at 20:10

BlackSpy

5,6035 gold badges33 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

xtofl · Accepted Answer · 2012-07-05 20:12:33Z

1

edit("+str+")

will result in the javascript code

edit(hi)

Where hi is an unknown variable. Depending on what you want the edit function to do, either add a quote: edit\""+str+"\"), or remove the plusses: edit(str). In the last case, the edit function will receive the str variable, in the first case, it will receive the "hi" literal.

answered Jul 5, 2012 at 20:12

xtofl

41.7k13 gold badges112 silver badges203 bronze badges

Comments

Alnitak · Accepted Answer · 2012-07-05 20:10:44Z

0

You're missing the double quotes necessary to make str a quoted string.

answered Jul 5, 2012 at 20:10

Alnitak

341k72 gold badges420 silver badges503 bronze badges

Collectives™ on Stack Overflow

Javascript string parameter in function

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related