Simplify this If statement so it doesn't duplicate code - Javascript

Question

I have an If statement that runs within a 'for' loop to create markers for a Google map. Basically if a tick box is not ticked it runs the code all displays all markers, but if a checkbox is ticked then it checks for a 2nd parameter and only runs the code for the items that match this condition.

The code I have below works fine, but it means I have to use the same code in both parts of the if statement. Apart from building it into a function if there a better way of structuring the If statement to achieve this?

if(!FriendlyChecked){

    //Code here

} else if(FriendlyChecked && Friendly == "Yes"){

    //Same code here

}

Your else if condition is redundant. If FriendlyChecked is true (in which case it will go to the else if statement) then why are you checking if FriendlyChecked is true again? — Aadit M Shah
– Aadit M Shah, Commented Jul 25, 2012 at 13:27

Jon Newmuis · Accepted Answer · 2012-07-25 13:22:40Z

9

If FriendlyChecked is false, the first condition is satisfied and the code will be executed.

Thus, if the second condition is reached, FriendlyChecked must be true, so you don't need to check it at all, you only need to check that Friendly == "Yes".

if(!FriendlyChecked || Friendly == "Yes"){
    // code here
}

answered Jul 25, 2012 at 13:22

Jon Newmuis

26.7k3 gold badges48 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

thecodeparadox · Accepted Answer · 2012-07-25 13:22:43Z

2

if( !FriendlyChecked || (FriendlyChecked && Friendly == "Yes") ) {

  // your code

}

!FriendlyChecked || (FriendlyChecked && Friendly == "Yes") will check for either FriendlyChecked is false (not checked)

OR FriendlyChecked is true an value of Friendly is Yes

answered Jul 25, 2012 at 13:22

thecodeparadox

87.2k22 gold badges143 silver badges164 bronze badges

1 Comment

Sphvn Over a year ago

Beat me to it by about 3 secs.

sashmarsh · Accepted Answer · 2012-07-25 13:32:27Z

0

This will solve your problem

 if((!FriendlyChecked) ||((FriendlyChecked)&&(Friendly == "Yes")){

 //Code here

}

edited Jul 25, 2012 at 13:32

answered Jul 25, 2012 at 13:27

sashmarsh

971 silver badge9 bronze badges

Collectives™ on Stack Overflow

Simplify this If statement so it doesn't duplicate code - Javascript

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related