Is there a way to simplify this javascript if-statement?

Question

not an expert on js but this if-statement still tickles me because I suspect it can be written in a way more clever fashion:

if(event.value == "/")
{
    event.value = "/home";
}

Suggestions?

What is it about the statement that you don't like? I mean, as statements go, that's pretty short already. — Pointy
– Pointy, Commented Dec 13, 2010 at 20:43
I came in here expecting a logic problem... this is a white-space problem. — Ryan Kinal
– Ryan Kinal, Commented Dec 13, 2010 at 20:47

Nick Craver · Accepted Answer · 2010-12-13 20:40:15Z

3

You could omit the braces:

if(event.value == "/") event.value = "/home";

Or a conditional:

event.value = event.value == "/" ? "/home" : event.value;

...but I'm not sure either of those is really "better", and a with statement you should just stay away from.

answered Dec 13, 2010 at 20:40

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

soren.qvist Over a year ago

Fast as always :) So that's basically like PHP I guess. Is there a shorter way to refer to event.value 'within' the brackets? Like: if(event.value == "/") sameval = "/home";

Nick Craver Over a year ago

@soren.qvist - There is, the with statement I liked above, but it's evil for a few reasons - and not available in all browsers.

Marc B · Accepted Answer · 2010-12-13 20:41:31Z

1

event.value = (event.value == "/") ? "/home" : event.value;

would be about the only other practical option. The if() version is far more readable in this case.

answered Dec 13, 2010 at 20:41

Marc B

362k44 gold badges433 silver badges508 bronze badges

Comments

Pimgd · Accepted Answer · 2010-12-13 20:42:17Z

1

if(event.value == "/"){
   event.value += "home";
}

answered Dec 13, 2010 at 20:42

Pimgd

6,0331 gold badge32 silver badges46 bronze badges

1 Comment

user447356 Over a year ago

Nice one, 1 less character to type. :)

GolezTrol · Accepted Answer · 2010-12-13 20:45:33Z

1

I don't think there's a better way. You could omit the braces if your coding style guide allows you to, but it won't semantically make a difference. The shorter event.value = (event.value == '/')?'/home':event.value; is not so good, because it makes a useless assignment when the value differs from '/'.

answered Dec 13, 2010 at 20:45

GolezTrol

116k19 gold badges186 silver badges215 bronze badges

Comments

Jonathon Bolster · Accepted Answer · 2010-12-13 20:49:52Z

1

There isn't much more you can do with it really, other than Nick's suggestions, but here's another way to throw into the mix:

event.value += (event.value == "/") ? "home" : "";

Another, just for fun:

event.value = ((function(v){ return v=="/" ? v+'home' : v }(event.value))

edited Dec 13, 2010 at 20:49

answered Dec 13, 2010 at 20:43

Jonathon Bolster

16k3 gold badges45 silver badges47 bronze badges

Comments

user447356 · Accepted Answer · 2010-12-13 21:12:20Z

0

You can put it into function to make it look better.

function GetValue(s1, s2, s3) {
   return s1 == s2 ? s3 : s1;
}

...

event.value = GetValue(event.value, "/", "/home");

IMO it's useful only if you need it more than once.

answered Dec 13, 2010 at 21:12

user447356

Collectives™ on Stack Overflow

Is there a way to simplify this javascript if-statement?

6 Answers 6

2 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

2 Comments

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related