C# ASP.NET MVC: Single-Line If Clause in View?

Question

I got a trivial issue.. and can't solve it.

I have this in my view:



<% if (!Model.DisplayText) { %> <%= Model.MyText %> <% } %>

As you can see, i am using 3x <% and %>. That just screams like bad code. But I can't seem to get this working in a single line. This throws all kinds of weird errors (such as semicolon missing, and when I add one it throws something else):



<% if (!Model.DisplayText) { Model.MyText } %>

Any idea?!

one of them actually writes to view content... that's your problem. — Robert Koritnik
– Robert Koritnik, Commented Jul 22, 2009 at 23:44
Just a note, the reason you're running into a no semicolon issue is because unlike "<%" which is for inline code, the "<%=" is for output and likely is transformed into a method call (something like page.write(Model.MyText);) when the page is parsed. — statenjason
– statenjason, Commented Jul 22, 2009 at 23:52
Your original code was fine. There is nothing inherently wrong with 3x <% %>'s. Just aim for clarity — mmcdole
– mmcdole, Commented Jul 23, 2009 at 0:54

tvanfosson · Accepted Answer · 2009-07-22 23:58:36Z

11

Try:

<%= Model.DisplayText ? "" : Model.MyText %>

or

<% if(!Model.DisplayText) Response.Write(Model.MyText); %>

edited Jul 22, 2009 at 23:58

tvanfosson

534k102 gold badges703 silver badges801 bronze badges

answered Jul 22, 2009 at 23:42

D'Arcy Rittich

172k41 gold badges298 silver badges287 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Odd Over a year ago

Beaten to the punch, nice post.

Alex Over a year ago

The ternary operator solution was exactly what I needed. Thank you! P.S. In that case there wouldn't be a semicolon so you may want to remove that for others that look up this solution. Thanks again!

Odd · Accepted Answer · 2009-07-22 23:46:36Z

1

is basically like writing Response.Write(your data) means the code will execute, but it's not going to specifically write anything out. You could use a Response.Write inside your if block to output the data you want.

Or go with OrbMan's answer, he beat me to it.

answered Jul 22, 2009 at 23:46

Odd

4,7776 gold badges33 silver badges27 bronze badges

1 Comment

Alex Over a year ago

All answers were great :) Thank you!

Pavel Minaev · Accepted Answer · 2009-07-23 01:34:55Z

1

This:

 <%= foo %>

is generally equivalent to:

 <% Response.Write(foo) %>

So you can write:

 <% if (!Model.DisplayText) { Response.Write(Model.MyText); } %>

but I don't see what you really get from this. Your original code is fine as it is. Or you might use the ternary operator, as OrbMan suggests.

edited Jul 23, 2009 at 1:34

answered Jul 22, 2009 at 23:46

Pavel Minaev

102k27 gold badges222 silver badges293 bronze badges

1 Comment

kastermester Over a year ago

You're missing a semi-colon after the call to Response.Write at the least, and this is probably a case where the brackets would best be left out.

Collectives™ on Stack Overflow

C# ASP.NET MVC: Single-Line If Clause in View?

3 Answers 3

2 Comments

1 Comment

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related