Embed Javascript function within Javascript function

Question

I need a function to determine: (1) if two inputs have values, throw an error. (2) if neither input has value, throw an error. (3) if input B or input D has a value, determine which Calculate function to then use. Both Calculate functions work, when called as

onClick="Calculate(this.form.input_A.value, this.form.input_B.value, this.form.input_C.value, this.form)"
onClick="Calculate2(this.form.input_A.value, this.form.input_C.value, this.form.input_D.value, this.form)"

But when I use to call the function below:

onclick="compute();"

The errors work, but I'm not calling the Calculate functions right, I'm sure its something obvious but I can't see it. The answer is no longer getting displayed, as it was before the error function was added.

<SCRIPT LANGUAGE="JavaScript">

function compute() {
  var B = document.getElementById("input_B").value;
  var D = document.getElementById("input_D").value;

  if (B != "" && D != "") {
    alert("You may only enter Assessment or Annual Property Taxes.");
  } else if (B != "") {
    Calculate(B);
  } else if (D != "") {
    Calculate2(D);
  } else {
    alert("You must enter a value into either Assessment or Annual Property Taxes.");
  }
}

function Calculate(Atext, Btext, Ctext, form) {
  var A = parseFloat(Atext);
  var B = parseFloat(Btext);
  var C = parseFloat(Ctext);
  form.Answer.value = ((B - A) * C) / 1000;
}

function Calculate2(Atext, Ctext, Dtext, form) {
  var A = parseFloat(Atext);
  var C = parseFloat(Ctext);
  var D = parseFloat(Dtext);
  form.Answer.value = D - ((A * C) / 1000);
}

function ClearForm(form) {
  form.input_A.value = "";
  form.input_B.value = "";
  form.input_C.value = "";
  form.input_D.value = "";
  form.Answer.value = "";
}

</SCRIPT>

Shouldn't you be passing more values into Calculate and Calculate2 than just "D" and "B"? — Chris Carew
– Chris Carew, Commented Aug 13, 2012 at 19:10
@ChrisCarew I tried adding in A + C to the compute function, to pass into Calculate and Calculate2, with no luck. I think I may be defining variables in different ways within the functions, causing confusion? Complete code is here: nhpta.com/over-tax-calculator1.4.2.html — Lauren
– Lauren, Commented Aug 13, 2012 at 19:24
A point on the site itself: you may find it beneficial to add a "this field required" indicator and somehow show which two fields are/are not required. — DACrosby
– DACrosby, Commented Aug 13, 2012 at 19:37

Ray Cheng · Accepted Answer · 2012-08-13 19:24:35Z

1

You are missing the arguments and not calling the functions correctly. Try the following...

function compute() {   
    var B = document.getElementById("input_B").value;   
    var D = document.getElementById("input_D").value;    
    var A = document.getElementById("input_A").value;   
    var C = document.getElementById("input_C").value; 

    if (B != "" && D != "") {     
        alert("You may only enter Assessment or Annual Property Taxes.");   
    } else if (B != "") {     
        Calculate(A, B, C, this.forms[0]);   
    } else if (D != "") {     
        Calculate2(A, C, D, this.forms[0]);   } 
    else {     
        alert("You must enter a value into either Assessment or Annual Property Taxes.");   
    } 
}

answered Aug 13, 2012 at 19:24

Ray Cheng

12.7k16 gold badges80 silver badges140 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Lauren Over a year ago

Still no luck, with either this.form[0] or this.forms[0]

DACrosby Over a year ago

Try it with document.getElementById("docForm") where "docForm" is the ID of your form.

Lauren Over a year ago

@DouglasA.Crosby Thank you - that did the trick, in addition to passing all the variables.

DACrosby · Accepted Answer · 2012-08-13 19:33:14Z

0

If your compute() function calls Calculate() and Calculate2() with only one parameter sent, you'll need to make new functions that only need one parameter.

function CalculateB(Btext) {
  var B = parseFloat(Btext);
  var form = document.getElementById("docForm");
  form.Answer.value = B / 1000;
}

function CalculateD(Dtext) {
  var D = parseFloat(Dtext);
  var form = document.getElementById("docForm");
  form.Answer.value = D - (1 / 1000);
}

answered Aug 13, 2012 at 19:33

DACrosby

11.5k3 gold badges42 silver badges52 bronze badges

Collectives™ on Stack Overflow

Embed Javascript function within Javascript function

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related