javascript function in javascript function

Question

I have some little code that I can't get to work. Here it is:

<input type='password' name='Confirmpwd' id='Confirmpwd'
       onkeyup="if(this.value != '') myFunction('checkConfirmpwd', (Password.value == this.value) ? 1 : 0;, this.id);" />

I'm 100% sure that Password.value and this.value are correct when I place them in there. So it's not a problem with the variables.

The problem is that, myFunction isn;t executed anymore when I try to compare Password.value and this.value in the argument like above. myFunction is declared like this:

myFunction(val1, val2, val3) { ...some code... }

What my goal is that I can compare the 2 strings and send them to myFunction when I call the function.

You seem to have an extra semicolon after the 0 in the second argument of the call to myFunction. That may just be a typo in your post here, but if it's in the original code, it would cause the call to fail with a syntax error. — Ted Hopp
– Ted Hopp, Commented Sep 14, 2014 at 17:34

Kami · Accepted Answer · 2014-09-14 20:45:01Z

1

The ; indicates an end of statement. If there are missing parameter or brackets that have not been closed when a semi-colon is encountered, it may result in an error.

This is the case in this instance.

Change the code to something like

if(this.value != '') myFunction('checkConfirmpwd', (Password.value == this.value) ? 1 : 0, this.id);

edited Sep 14, 2014 at 20:45

answered Sep 14, 2014 at 17:38

Kami

19.5k4 gold badges53 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

slebetman Over a year ago

Except for command languages like Tcl or bash, most languages don't really have the concept of "command". It's the end of a statement.

Kami Over a year ago

@slebetman : see - developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/…. Although I understand the confusion and have reworded it.

DevilishDB · Accepted Answer · 2014-09-14 18:04:24Z

1

Put the onkeyup in an external javascript file rather than the same HTML file. It's better to do this for ease-of-editing and performance:

HTML

<input type="password" name="Confirmpwd" id="Confirmpwd" />

JS

document.getElementById("Confirmpwd").onkeyup = function () {
    "use strict";
    if (this.value !== "") { // !== is better than !=
        myFunction("checkConfirmpwd", (Password.value === this.value) ? 1 : 0, this.id); // === is better than ==
    }
};

And all we did there was change ;, to ,. It was just a typo

edited Sep 14, 2014 at 18:04

answered Sep 14, 2014 at 17:44

DevilishDB

6157 silver badges12 bronze badges

6 Comments

Ted Hopp Over a year ago

It's a good idea to put the code in a function that's parsed when the JS is loaded, but how does it improve security?

Krowi Over a year ago

Imo putting it in the onkeyup part will hide the script, right? -> More security?

DevilishDB Over a year ago

@TedHopp Since you can "sandbox" the external script (wrap it in (function { // code }())) to avoid other scripts overwriting functions which you've used in an on<something> attribute.

DevilishDB Over a year ago

@TedHopp @Krowi No, actually, because with debugging tools you can simply pause the javascript, then onkeyup the input and the debugger will show you where the code is. It's so hackers can't overwrite your functions as easily.

Ted Hopp Over a year ago

Hackers can simply assign a different onkeyup property to intercept the call and do whatever they want (including tracing into the original code to see what it does). There's no real increase in security here.

|

Collectives™ on Stack Overflow

javascript function in javascript function

2 Answers 2

2 Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related