I cannot get a return code from my javascript function

Question

I assign the following to a button on a modal. When the user clicks on the button it calls submitHandler.

   var btn = {
        'Submit & Close': function (win) {
            var rc = submitHandler(oLink.$link, $modal);
            $('#createLink').prop('disabled', false);
        },
        'Close': function (win) {
            $modal.closeModal();
            $('#createLink').prop('disabled', false);
        }
    }

My submitHandler looks like this:

    function submitHandler($link, $modal) {

  if (!$form.valid || $form.valid()) {
        $submitBt.disableBt();
        $modal.removeBlockMessages()
            .blockMessage('Contacting Server, please wait ... ', { type: 'loading' });
        $.ajax({
            url: oSubmit.href,
            dataType: 'json',
            type: 'POST',
            data: $form.serializeArray()
        })
        .done(function (json, textStatus, XMLHttpRequest) {
            json = json || {};
            if (json.success) {
                submitSuccessModal(oSubmit, json);
                return true;
            } else {
                submitFailModal(oSubmit, json);
                return false;
            }
            return false;
        })

    }

When I check in the debugger submitHandler runs but when I look at the value of rc it is undefined.

Is there something obvious I am missing. I simply cannot get rc to equal anything other than "undefined".

Update:

I added in an actual section of the code. I am wondering if it could be the ajax call that's causing this? Note that I can follow the code with the debugger to the return true; line.

possible duplicate of Return value from ajax call? see SLaks' answer (do not use async: false). — Matt Ball
– Matt Ball, Commented Aug 21, 2012 at 17:55

Matt Ball · Accepted Answer · 2012-08-21 16:11:59Z

5

Statements are terminated with semicolon, not colon.

function submitHandler($link, $modal) {
   return true;
}          // ↑

answered Aug 21, 2012 at 16:11

Matt Ball

361k102 gold badges655 silver badges725 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Selvakumar Arumugam Over a year ago

How did you type ↑ in your post? +1 for quick find.

Samantha J T Star Over a year ago

Sorry. That was a type. My actual code does use a semicolon. I am totally confused as to why it might not work.

Matt Ball Over a year ago

@Vega fileformat.info/info/unicode/char/2191/index.htm or just type ↑ in a non-code block, then Ctrl-C Ctrl-V.

Selvakumar Arumugam Over a year ago

@MattBall Thanks..Also the OP question is about async return value from ajax call.

Matt Ball Over a year ago

@Vega yes, it's the typical "ajax is asynchronous problem," looking for a dup to close as.

Alfabravo · Accepted Answer · 2012-08-21 16:12:37Z

2

Check the semicolon at the end of the return statement in the handler.

function submitHandler($link, $modal) {
   return true;
}

answered Aug 21, 2012 at 16:12

Alfabravo

7,5786 gold badges49 silver badges83 bronze badges

Collectives™ on Stack Overflow

I cannot get a return code from my javascript function

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related