android - sharedpreferences return null value

Question

I'm trying to use sharedpreferences to check whether the user logged in before they start using the app. I save the username in shredpreferences when user log in.

Login.java

public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.login);     
        Button btnLogin = (Button) findViewById(R.id.buttonlogin);      
        btnLogin.setOnClickListener(new View.OnClickListener() {
            public void onClick(View adapt) {
                EditText usernameEditText = (EditText) findViewById(R.id.EditUserName);
                userName = usernameEditText.getText().toString();
                EditText passwordEditText = (EditText) findViewById(R.id.EditPassword);
                userPassword = passwordEditText.getText().toString();               
                if (userName.matches("") && userPassword.matches("")) {
                    toast("Please enter Username and Password");
                    return;
                } else if (userName.matches("") || userName.equals("")) {
                    toast("Please enter Username");
                    return;
                } else if (userPassword.matches("") || userPassword.equals("")) {
                    toast("Please enter Password");
                    return;
                } else {
                    SharedPreferences sharedPreferences = getPreferences(MODE_PRIVATE);
                    SharedPreferences.Editor editor = sharedPreferences.edit();
                    editor.putString("MEM1", userName);
                    editor.commit();
                    new DownloadFilesTask().execute();
                }           
            }
        });
    }

    private void toast(String text) {
        Toast.makeText(this, text, Toast.LENGTH_SHORT).show();
    }

    private class DownloadFilesTask extends AsyncTask<Void, Void, Void> {
        protected void onPreExecute() {
        }

        protected void onPostExecute(Void result) {
            toast("user logged in");
            startActivity(new Intent(Login.this, MainActivity.class));
            finish();
        }

        @Override
        protected Void doInBackground(Void... params) {         
            return null;
        }
    }

}

and I tried to check the username value before I start my mainactivity.

SharedPreferences sharedPreferences = getPreferences(MODE_PRIVATE);
    String username =sharedPreferences.getString("MEM1", "");
    if(username.equalsIgnoreCase("")||username.length()==0)
    {
        toast("username is null");
        startActivity(new Intent(MainActivity.this, Login.class));
        finish();
    }

but the username is always null. Please help. Thanks

If your username ever was null your app would crash because it's not possible to call a method of a null value. And if you want to check for empty strings it's better to use isEmpty(). — The incredible Jan
– The incredible Jan, Commented Jan 18, 2018 at 13:16

Zyber · Accepted Answer · 2012-09-19 06:48:43Z

27

Calling getPreferences means that you have to be in the same activity. Using getSharedPreferences allows you to share the preferences between activities. You just have to define a name for the preferences when calling getSharedPreferences("Pref name here", MODE_PRIVATE);

answered Sep 19, 2012 at 6:48

Zyber

1,0348 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dipak Keshariya · Accepted Answer · 2012-09-19 06:46:08Z

17

Write below Code instead of your code to save username into sharedpreferences.

SharedPreferences myPrefs = this.getSharedPreferences("myPrefs", MODE_WORLD_READABLE);
SharedPreferences.Editor editor = myPrefs.edit();
editor.putString("MEM1", userName);
editor.commit();

And Use below code For Get Preferences Value.

SharedPreferences myPrefs = this.getSharedPreferences("myPrefs", MODE_WORLD_READABLE);
String username = myPrefs.getString("MEM1","");

answered Sep 19, 2012 at 6:46

Dipak Keshariya

22.3k18 gold badges80 silver badges129 bronze badges

1 Comment

Wiguna R Over a year ago

Hi, im from future. MODE_WORLD_READABLE is deprecated in API level 17, it says "Creating world-readable files is very dangerous, and likely to cause security holes in applications" The solution is using MODE_PRIVATE

Nicu P · Accepted Answer · 2015-06-10 17:30:18Z

1

private final String TAXI_SPREF = "TAXI_SHARED_PREFERENCES";

//set-save data to shared preferences
SharedPreferences.Editor sPEditor = getSharedPreferences(TAXI_SPREF, MODE_PRIVATE).edit();
sPEditor.putInt("USERID", etUserID.getText().toString());
sPEditor.putString("EMAIL", etEmail.getText().toString());
sPEditor.apply();

//get data from shared preferences

SharedPreferences sharedPreferences = getSharedPreferences(TAXI_SPREF, MODE_PRIVATE);
int userID = sharedPreferences.getInt("USERID", 0);
string email = sharedPreferences.getString("EMAIL", 0);
////////     or         /////
String email = getSharedPreferences(TAXI_SPREF, MODE_PRIVATE).getString("EMAIL","EMPTY");
    if (!email.equals("EMPTY")){
        etEmail.setText(email);
    }

edited Jun 10, 2015 at 17:30

answered Jun 2, 2015 at 15:13

Nicu P

2532 silver badges6 bronze badges

Collectives™ on Stack Overflow

android - sharedpreferences return null value

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related