SharedPreferences returning an empty string

Question

Why does the toast only show an empty string or whatever I input as the "default" value on the getString line

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    SharedPreferences sharedPreferences = this.getSharedPreferences("com.example.stefan.dijeljenepreference", Context.MODE_PRIVATE);
    sharedPreferences.edit().putString("username", "stefan");

    String username = sharedPreferences.getString("username","");
    Toast.makeText(this,"username:" + username, Toast.LENGTH_SHORT).show();
}

Missing apply call after the putString

Rizwan
– Rizwan

2017-10-04 16:20:41 +00:00
Commented Oct 4, 2017 at 16:20 — Rizwan
– Rizwan, Commented Oct 4, 2017 at 16:20
you didn't use apply() or commit() after edit that's why

Shubham Jain
– Shubham Jain

2017-10-04 16:21:54 +00:00
Commented Oct 4, 2017 at 16:21 — Shubham Jain
– Shubham Jain, Commented Oct 4, 2017 at 16:21
Awesome, that was it, thanks.

Nikocevic Stefan
– Nikocevic Stefan

2017-10-04 16:21:57 +00:00
Commented Oct 4, 2017 at 16:21 — Nikocevic Stefan
– Nikocevic Stefan, Commented Oct 4, 2017 at 16:21

an_droid_dev · Accepted Answer · 2017-10-04 16:18:55Z

1

You should save your edits using apply() method like this

sharedPreferences.edit().putString("username", "stefan").apply();

answered Oct 4, 2017 at 16:18

an_droid_dev

1,13614 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

an_droid_dev Over a year ago

@NikocevicStefan glad to help you

Collectives™ on Stack Overflow

SharedPreferences returning an empty string

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related