JavaScript regex replace not working?

Question

I have this JavaScript code:

var test123 = $('product-price-' + productId).innerHTML; // thats 26,00&nbsp;€
var finalPrice = test123.replace(/[^\d.,]/, "");

Testing my regex here: http://www.regular-expressions.info/javascriptexample.html correctly returns me 26,00, exactly what I want. Why is it not working in my code? In my code it replaces nothing at all.

Thanks!

@DavidThomas That doesn't looks like jQuery. I think that it's MooTools (or any other library where $ is a shortcut for document.getElementById). — Rob W
– Rob W, Commented Sep 24, 2012 at 12:24

Alex K. · Accepted Answer · 2012-09-24 12:18:50Z

2

Escape the period and add g to make it global;

/[^\d\.,]/g

answered Sep 24, 2012 at 12:18

Alex K.

177k32 gold badges276 silver badges299 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

verdesmarald Over a year ago

Escaping the period is unnecessary inside a character class.

user1638055 Over a year ago

@verdesmarald: Exactly, the problem must be somewhere else, but the g made it work. Solution: By adding the g I made it work.

verdesmarald Over a year ago

@user1638055 The g modifier part is correct and will solve your problem.

user1638055 Over a year ago

Yeah, I noticed now, too. Can you explain why please?

verdesmarald Over a year ago

@user1638055 g is a modifier to make the regex "global". Without g, the regex is only applied to the first match (so in your case it matches just & in 26,00 €), with g it is applied to every match in the string (so it matches &, n, b, s, p, ; and €).

Collectives™ on Stack Overflow

JavaScript regex replace not working?

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related