Javascript regex Replace doesn't work

Question

I can't, for the life of me, figure out how to replace all [ with < and all ] with > in a value in JavaScript.

Here's what I've tried and it just doesn't work:

function SwitchDialog(NextDialog)
{
    if (NextDialog=='SCHEDULE') {
        $('.popup1').smart_modal_hide();
    } else if (NextDialog=='LICENSEE') {
        gotoLicensee(licenseeLink);
    } else if (NextDialog=='REVIEWCART') {
        window.location = CART_URL;
    } else if (NextDialog=='RFO') {
        window.location = REGISTER_FOR_OTHERS_URL;
    } else {
        if (NextDialog=='PREREG') {
            var msgtxt = gk_text.replace(//[/g, '<');
            msgtxt     = msgtxt.replace(//]/g, '>');
            DialogTemps[NextDialog].msgtext = msgtxt; // error occurs on this line
        }
        RenderDialog(NextDialog);
    }
}

I get a Syntax error: "missing ) after argument list at the ; on the line that assigns the msgtext.

What the heck am I doing wrong?

@Maccath: To do multiple replaces you need a global regex.

I Hate Lazy
– I Hate Lazy

2012-11-16 20:42:08 +00:00
Commented Nov 16, 2012 at 20:42 — I Hate Lazy
– I Hate Lazy, Commented Nov 16, 2012 at 20:42
You're right, sorry, blonde moment. :P

Maccath
– Maccath

2012-11-16 20:47:29 +00:00
Commented Nov 16, 2012 at 20:47 — Maccath
– Maccath, Commented Nov 16, 2012 at 20:47

Kael Rowan · Accepted Answer · 2012-11-16 20:41:52Z

6

You need to escape the [ and ] characters in your expression with a backslash (\), like so:

        var msgtxt = gk_text.replace(/\[/g, '<');
        msgtxt     = msgtxt.replace(/\]/g, '>');

answered Nov 16, 2012 at 20:41

Kael Rowan

1186 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

I Hate Lazy · Accepted Answer · 2012-11-16 20:46:05Z

4

You commented out the closing ), hence the error.

You need to escape a / in a regex, and not a bad idea to escape the [ and ] as well, ~~even though it's likely not needed here~~.

var msgtxt = gk_text.replace(/\/\[/g, '<');
msgtxt     = msgtxt.replace(/\/\]/g, '>');

edited Nov 16, 2012 at 20:46

answered Nov 16, 2012 at 20:38

I Hate Lazy

49k13 gold badges89 silver badges79 bronze badges

4 Comments

MB34 Over a year ago

It's a freaking regex expression

I Hate Lazy Over a year ago

@MB34: "It's a freaking regex expression" Not when you make it a feaking code comment.

MB34 Over a year ago

I stand corrected. I am not good at Regex, as evidenced by my attempt. I went to regex101.com and built it and it looks just like the one you posted and works correctly, thanks. I will accept once I'm able.

I Hate Lazy Over a year ago

@MB34: If you didn't want to include the / character in the regex, then you should accept the other answer.

Ωmega · Accepted Answer · 2012-11-16 21:12:42Z

0

You need to escape [ and ] characters with \, as then have special meaning in regex.

var msgtxt = gk_text.replace(/\[/g, '<').replace(/\]/g, '>');

answered Nov 16, 2012 at 21:12

Ωmega

44k35 gold badges143 silver badges213 bronze badges

Collectives™ on Stack Overflow

Javascript regex Replace doesn't work

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related