PHP, Cutting String

Question

I have this string(245) "- Current Map = VILLA - Current Missions = VEGAS JUNKYARD, VILLA, PRESIDIO, KILL HOUSE, STREETS, THREE KINGDOMS CASINO; - Available Missions = TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER;"

Current Map is always one value, Current Missions and Availible Missions have a variable amount of values.

I would like to parse the string so that I have an array that looks like this:

Array ([Current Map] => VILLA [Current Missions] => Array ([0] => VEGAS JUNKYARD [1] => VILLA [2] => PRESIDIO [3] => KILL HOUSE [4] => STREETS [5] => THREE KINGDOMS CASINO)  [Availible Missions] => Array ([0] => TRAINYARD [1] => IMPORT/EXPORT [2] => MURDERTOWN [3]  => CQB TRAINING [4] => OIL REFINERY [5] => CONVENTION CENTER [6] => THEATER))

What works: It seperates the 3 big parts (Current Map, Current Missions, Availible Missions)

What doesn't work: Seperating the multiple values of "Current Missions" and "Availible Missions" into an array.

Bug (or I'm just stupid):Notice the semicolon before "Availible Missions"

$search_strs_maps = array('Current Map = ', '- Current Missions = ', '; - Available  Missions = ', ';');

If I put the semicolon there it doesnt find anything even though I'm pretty sure the semicolon is in the string.

Reason I'm putting this up is that I can' figure out why it doesnt find anything when I put the semicolon before "Availible Missions" and it's driving me crazy. Also I could use a second set of eyes on the code and some advice on how to make it nicer. Thanks for your help!

This is what I have written so far.

<?php
$str_map = '- Current Map = VILLA - Current Missions = VEGAS JUNKYARD, VILLA, PRESIDIO,  KILL HOUSE, STREETS, THREE KINGDOMS CASINO; - Available Missions = TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER;';
$search_strs_maps = array('Current Map = ', '- Current Missions = ', '- Available  Missions = ', ';');
for ($i=0; $i<3; $i++){

                $str_map = trim ($str_map);
                output($str_map, 'Complete String');
                //Cut of the beginning : "- Current Map = "
                $start_pos = str_pos_last ($str_map,  $search_strs_maps[$i]);
                output($start_pos, 'Starting position');
                $str_map = substr($str_map, $start_pos);
                output($str_map, 'String after first cut:');
                //Cut the remaining part to "Current Missions ="
                $end_pos = strpos ($str_map, $search_strs_maps[$i+1]);
                output($end_pos, 'End position');
                //Save the new string without for example "VILLA"
                $ergebnis = substr($str_map, 0, $end_pos);
                $ergebnis = trim ($ergebnis);
                output($ergebnis, 'Finished result');
                $str_map = substr($str_map, $end_pos);
                echo '<hr>';
                if ($i==0){
                    $arr_return_strs['current_map'] = $ergebnis;
                }else{  //arrays
                    //stupid semicolon that doesnt get cut of
                    $ergebnis = str_replace ($str_map, ';', '');
                    $arr_maps_temp = array();
                    //count the number of commas, if there is one comma that means there are 2 words, there is no comma at the end
                    $map_count = substr_count ($ergebnis, ',')+1;
                    for ($ii=0;$ii<$map_count;$ii++){
                        echo '<hr';
                        //cut at first comma
                        $result_pos = strpos($str_map, ',');
                        //save
                        $result_map = substr($str_map, 0, $result_pos);
                        //cut of the result+comma
                        $ergebnis = substr ($ergebnis, $result_pos);
                        output($result_map, 'Result is:');
                    }
                }

            }
    echo '<hr><hr><hr>';
    print_r ($arr_return_strs);

function str_pos_last ($input_str, $search_str, $offset=0){
    //this function returns the endposition of a string we search for, strpos returns the beginning...
    $str_begin = strpos ($input_str, $search_str);
    $str_end = $str_begin + strlen($search_str);
    return $str_end;
}

function output ($var, $desc){
echo $desc.'<br>';
var_dump ($var);
echo '<hr>';
}
?>

Mark Baker · Accepted Answer · 2012-10-14 11:49:50Z

2

$initialString = "- Current Map = VILLA - Current Missions = VEGAS JUNKYARD, VILLA, PRESIDIO, KILL HOUSE, STREETS, THREE KINGDOMS CASINO; - Available Missions = TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER;";


$resultArray = array();
$blockArray = explode('-',$initialString);
foreach($blockArray as $setArray) {
    if (!empty($setArray)) {
        list($dataArrayKey, $dataArrayValues) = explode('=',$setArray);
        $dataArrayKey = trim($dataArrayKey);
        $dataArrayValues = trim($dataArrayValues,' ;');
        if ($dataArrayKey == 'Current Map') {
            $resultArray[$dataArrayKey] = trim($dataArrayValues);
        } else {
            $dataArrayValues = explode('=', $dataArrayValues);
            foreach($dataArrayValues as $dataArrayValue) {
                $dataArrayEntries = explode(',',$dataArrayValue);
                $resultArray[$dataArrayKey] = $dataArrayEntries;
            }
        }
    }
}

var_dump($resultArray);

gives

array
  'Current Map' => string 'VILLA' (length=5)
  'Current Missions' => 
    array
      0 => string 'VEGAS JUNKYARD' (length=14)
      1 => string ' VILLA' (length=6)
      2 => string ' PRESIDIO' (length=9)
      3 => string ' KILL HOUSE' (length=11)
      4 => string ' STREETS' (length=8)
      5 => string ' THREE KINGDOMS CASINO' (length=22)
  'Available Missions' => 
    array
      0 => string 'TRAINYARD' (length=9)
      1 => string ' IMPORT/EXPORT' (length=14)
      2 => string ' MURDERTOWN' (length=11)
      3 => string ' CQB TRAINING' (length=13)
      4 => string ' OIL REFINERY' (length=13)
      5 => string ' CONVENTION CENTER' (length=18)
      6 => string ' THEATER' (length=8)

answered Oct 14, 2012 at 11:49

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Diemex Over a year ago

Why do you use the second foreach loop? I don't understand it's purpose. Couldnt you just put "$dataArrayValues = explode(',',$dataArrayValues); $resultArray[$dataArrayKey] = $dataArrayValues;"

Mark Baker Over a year ago

I could have done.... I should also have trimmed the $dataArrayValue entries as well, because there's a spurious space at the start of all current and available mission entries (except for the first). I was just trying to provide a quick and easy answer that didn't involve all that complex strpos/substr etc to show that explodes and trims could do the job more easily and efficiently

gtht90 · Accepted Answer · 2012-10-14 11:56:31Z

Why not use http://php.net/preg_match

$str = "- Current Map = VILLA - Current Missions = VEGAS JUNKYARD, VILLA, PRESIDIO, KILL HOUSE, STREETS, THREE KINGDOMS CASINO; - Available Missions = TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER;"

preg_match('~Current Map = (.*?) - Current Missions = (.*?); - Available Missions = (.*?);~ism',$str,$matches);
echo '<pre>';
print_r($matches);

Array
(
 [0] => Current Map = VILLA - Current Missions = VEGAS JUNKYARD, VILLA, PRESIDIO, KILL HOUSE, STREETS, THREE KINGDOMS CASINO; - Available Missions = TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER;
 [1] => VILLA
 [2] => VEGAS JUNKYARD, VILLA, PRESIDIO, KILL HOUSE, STREETS, THREE KINGDOMS CASINO
 [3] => TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER
)

Then you can explode the results

billyonecan · Accepted Answer · 2012-10-14 12:45:24Z

Similar to the other examples, but simpler (where $str is the input string):

$types = array_map('trim', explode('-', substr($str, 1, strlen($str))));
$output = array();

foreach ($types as $value) {
  $type = array_map('trim', explode('=', str_replace(';', '', $value)));
  $opts = array_map('trim', explode(',', $type[1]));
  $output[$type[0]] = (count($opts) == 1) ? $opts[0] : $opts;      
}

var_dump($output);

outputs

array
  'Current Map' => string 'VILLA' (length=5)
  'Current Missions' => 
    array
      0 => string 'VEGAS JUNKYARD' (length=14)
      1 => string 'VILLA' (length=5)
      2 => string 'PRESIDIO' (length=8)
      3 => string 'KILL HOUSE' (length=10)
      4 => string 'STREETS' (length=7)
      5 => string 'THREE KINGDOMS CASINO' (length=21)
  'Available Missions' => 
    array
      0 => string 'TRAINYARD' (length=9)
      1 => string 'IMPORT/EXPORT' (length=13)
      2 => string 'MURDERTOWN' (length=10)
      3 => string 'CQB TRAINING' (length=12)
      4 => string 'OIL REFINERY' (length=12)
      5 => string 'CONVENTION CENTER' (length=17)
      6 => string 'THEATER' (length=7)

Night2 · Accepted Answer · 2012-10-14 11:57:42Z

Here is what you want:

<?php

$str = '- Current Map = VILLA - Current Missions = VEGAS JUNKYARD, VILLA, PRESIDIO, KILL HOUSE, STREETS, THREE KINGDOMS CASINO; - Available Missions = TRAINYARD, IMPORT/EXPORT, MURDERTOWN, CQB TRAINING, OIL REFINERY, CONVENTION CENTER, THEATER;';

$parts = str_replace(array('- ', ';'), '', explode(' - ', $str));

foreach($parts AS $key => $part){
    $parts[$key] = explode(' = ', $part);
    if($key != 0){
        $parts[$key][1] = explode(', ', $parts[$key][1]);
    }
}

$final_array = array();
foreach($parts AS $part){
    $final_array[$part[0]] = $part[1];
}

print_r($final_array);

?>

Output:

Array
(
    [Current Map] => VILLA
    [Current Missions] => Array
        (
            [0] => VEGAS JUNKYARD
            [1] => VILLA
            [2] => PRESIDIO
            [3] => KILL HOUSE
            [4] => STREETS
            [5] => THREE KINGDOMS CASINO
        )

    [Available Missions] => Array
        (
            [0] => TRAINYARD
            [1] => IMPORT/EXPORT
            [2] => MURDERTOWN
            [3] => CQB TRAINING
            [4] => OIL REFINERY
            [5] => CONVENTION CENTER
            [6] => THEATER
        )

)

Collectives™ on Stack Overflow

PHP, Cutting String

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related