passing PHP string to JavaScript: unterminated string literal

Question

i am assigning PHP var to my javascript var and sending to PHP file through ajax-jQuery, but my php variable contains newline chars which i have replaced with <br>

e.g.            $values1 = 'abc<br>pqr<br>xyz';  $values2 = 'xyz<br>lmn';
javascript -    var data = 'val1=<?php echo $values; ?>&val2=<?php echo $values2; ?>';

and then ajax script to post data to PHP file

but when i print this data on console it is giving me error- SyntaxError: unterminated string literal.

Can anyone help ?

chat.stackoverflow.com/rooms/26688/maharashtrian-code-worriars — Freelancer
– Freelancer, Commented Apr 2, 2013 at 11:53

anubhava · Accepted Answer · 2012-10-16 10:05:21Z

2

Your JS code:

var data = 'val1=<?php echo $values1; ?>&val2=<?php echo $values2; ?>';

Will give Javascript syntax error if one or more of your PHP variables $values1 OR $values2 contain single quote ' in them.

Make sure your PHP variable don't contain single quotes in them by replacing all single quotes to something else otherwise use double quotes " to create JS var like this:

var data = "val1=<?php echo $values1; ?>&val2=<?php echo $values2; ?>";

Provided PHP variables don't contain double quotes.

answered Oct 16, 2012 at 10:05

anubhava

790k67 gold badges603 silver badges671 bronze badges

Sign up to request clarification or add additional context in comments.

15 Comments

Sunil Lohar Over a year ago

i dont have issue with ajax data post to php, but even though when i try to print on console e.g. console.log('<?php echo $values1; ?>') it is giving error

anubhava Over a year ago

You need to print it like this: console.log("<?php echo $values1; ?>") actually.

Sunil Lohar Over a year ago

sorry, my mistake here,i am already using console.log('<?php echo $values1; ?>'), still same error

anubhava Over a year ago

Can you print it like this: console.log("<?php echo $values1; ?>"); note I am using " intead of '

anubhava Over a year ago

And you're viewing this output in shell or browser? If inside shell then this is indeed the cause of the problem since your string contains new line characters.

|

VisioN · Accepted Answer · 2012-10-16 10:05:11Z

0

First of all, you have a typo, that might cause an error:

// --------------------------------v
var data = 'val1=<?php echo $values1; ?>&val2=<?php echo $values2; ?>';

Then, I suggest you to use object as data parameter for Ajax request:

var data = {
    val1: '<?php echo $values1; ?>',
    val2: '<?php echo $values2; ?>'
};

Also it is better to escape single quotes ' in both $values1 and $values2 variables.

answered Oct 16, 2012 at 10:05

VisioN

146k35 gold badges287 silver badges291 bronze badges

6 Comments

Sunil Lohar Over a year ago

thanks Vision , but i dont think its typo, coz it is working if i remove <br>.

Sunil Lohar Over a year ago

i dont have issue with ajax data post to php, but even though when i try to print on console e.g. console.log('<?php echo $values1; ?>') it is giving error

VisioN Over a year ago

You should surround the value with quotes: console.log('<?php echo $values1; ?>').

Sunil Lohar Over a year ago

sorry, my mistake here,i am already using console.log('<?php echo $values1; ?>'), still same error

VisioN Over a year ago

Try to add slashes: console.log('<?php echo addslashes($values1); ?>');.

|

Armaggedon · Accepted Answer · 2012-10-16 10:07:26Z

-1

Try using <br /> instead of <br>. Just guessing here, no testing.

answered Oct 16, 2012 at 10:07

Armaggedon

4195 silver badges14 bronze badges

Collectives™ on Stack Overflow

passing PHP string to JavaScript: unterminated string literal

3 Answers 3

15 Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

15 Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related