Why isn't my php script working?

Question

EDIT: Apparently I have to pay to register another domain on their site to have email capabilities. Sorry for the wasted time, and thanks for the code fixes.

I don't have any experience with php. I am just starting to figure it out. I am trying to get my form to send the entered information to my email. I set an else tag but that is all that happens. If you see any errors please let me know. I really want this to work. See for yourself: Website The codes are:

HTML:

<form action="post_comment.php" method="post" id="commentform">

<label for="comment_author" class="required">Your Name</label>
<input name="name" id="name" tabindex="1" required="required"><br/><br/>

<label for="email" class="required">Your Email</label>
<input type="email" id="email" name="email" id="email" value="" tabindex="2"   required="required"><br/><br/>

<label for="comment" id="comment" class="required">Your Message</label><br/>

<textarea name="comment" rows="10" tabindex="4"  required="required"></textarea><br/>
<input id="submit" name="submit" type="submit" value="Submit Comment" />
<input id="send" name="send" type="hidden" value="1" />

</form>

PHP:

    <?php
    $name = $_POST['name'];
    $email = $_POST['email'];
    $message = $_POST['comment'];
    $from = 'From: '. $email; 
    $to = '[email protected]'; 
    $subject = 'WEBSITE';

    $body = "From: $name\n E-Mail: $email\n Message:\n $message";

    if ($_POST['send'] == "1") { 
        if (mail($to, $subject, $body, $from)) { 
        echo '<p>Your message has been sent!</p>';
    } else { 
        echo '<p>Something went wrong, go back and try again!</p>'; 
    }}
?>

I get Something went wrong, go back and try again! when I'm trying to submit the form. Updated code.

well because I have the else tag it just defaults and shows 'Something went wrong...' — user1753162
– user1753162, Commented Oct 17, 2012 at 12:51
I edited your question and added the output after going to your website and trying to submit the form. — Ofir Baruch
– Ofir Baruch, Commented Oct 17, 2012 at 12:52
edited my answer; your mail() call's parameters are wrong, specifically $body. — Pedro del Sol
– Pedro del Sol, Commented Oct 17, 2012 at 13:14

Pedro del Sol · Accepted Answer · 2012-10-17 13:13:33Z

4

<form action="post_comment.php" method="post" id="commentform">

rather than method="request"

edited to add http://www.w3.org/TR/html401/interact/forms.html#h-17.13.1

edited (in response to edited question code...) to add http://php.net/manual/en/function.mail.php

your mail() parameters are in the wrong order; should be $to, $subject, $message [, $additional_headers, etc.]

edited Oct 17, 2012 at 13:13

answered Oct 17, 2012 at 12:51

Pedro del Sol

2,8419 gold badges43 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

nickhar Over a year ago

And then use $_POST['comment'] etc to access the form values!

Pedro del Sol Over a year ago

good spot @nickhar; just saw the error in the form, didn't look that closely at the php...

user1753162 Over a year ago

Ok. It still gives me the same message though.

Pedro del Sol Over a year ago

did you change the $_REQUEST['etc...'] to $_POST like nickhar suggested?

Ofir Baruch Over a year ago

@PedrodelSol , the order of the parameters are fine as far as I'm concern.

Ofir Baruch · Accepted Answer · 2012-10-17 13:31:44Z

3

According to your code:

   if ($_REQUEST['submit']) {               
        if (mail($to, $subject, $body, $from))
        { 
           echo '<p>Your message has been sent!</p>';
        }
        else
        { 
           echo '<p>Something went wrong, go back and try again!</p>'; 
        }
   }

Getting the output of:

Something went wrong, go back and try again!

Means that something went wrong with the mail() function, it returned false , otherwise we would see the Your message has been sent! message.

The problem with the mail() function is that it doesn't show any errors or warning , it just returns false.

How to locate the problem?

Try writing something like:

    if(mail("[email protected]" , "A subject for example" , "the content of this email","From: [email protected]"))
     echo "We are good";
    else
     echo "Something not workin";

If it works , check out the value of any of your posted variables right after declaring them.

   echo $name;
   echo $email;
   echo $message;

Make sure that those variables are not empty and that the $email variable contains a legal and validated email address.

If the basic mail usage didn't work - it's something related to your php settings (php.ini) or a limitation by your server (contact your hosting company).

EDIT1: About your html form , the type attribute of the input fields should be text and not name or email.

Instead of <input type="email"... Write <input type="text"...

edited Oct 17, 2012 at 13:31

answered Oct 17, 2012 at 13:10

Ofir Baruch

10.3k2 gold badges29 silver badges39 bronze badges

7 Comments

user1753162 Over a year ago

so how would I test this? new temporary php and link it to my submit button?

Ofir Baruch Over a year ago

Have a new php file only with the mail function (as I wrote) , then follow the instructions and share with us the results.

user1753162 Over a year ago

I made the php file but what do I do with it? link it to my submit button on my page?

Ofir Baruch Over a year ago

No , just upload it and run it. For instance , bla.php - visit yourdomain.com/path/to/bla.php. Write here what's the output of this url.

user1753162 Over a year ago

Ok. Sent me to a blank page with no email. So... Server limitations? -_-

|

Arun Killu · Accepted Answer · 2012-10-17 12:52:21Z

3

<form action="post_comment.php" method="get" id="commentform">

<label for="comment_author" class="required">Your Name</label>
<input name="name" id="name" tabindex="1" required="required"><br/><br/>

<label for="email" class="required">Your Email</label>
<input type="email" id="email" name="email" id="email" value="" tabindex="2"   required="required"><br/><br/>

<label for="comment" id="comment" class="required">Your Message</label><br/>

<textarea name="comment" rows="10" tabindex="4"  required="required"></textarea><br/>
<input id="submit" name="submit" type="submit" value="Submit Comment" />

</form>

method must be get/post

answered Oct 17, 2012 at 12:52

Arun Killu

14.3k5 gold badges38 silver badges66 bronze badges

Comments

vandango · Accepted Answer · 2012-10-17 12:53:20Z

3

Your field "submit" is a HTML button to submit the form and will not be added to the form. Add another input field which is not visible:

<input id="send" name="send" type="hidden" value="1" />

and access the field in PHP with:

if ($_REQUEST['send'] == "1") {

I hope this helps you.

answered Oct 17, 2012 at 12:53

vandango

5671 gold badge4 silver badges13 bronze badges

2 Comments

user1753162 Over a year ago

ok I added that. The second one replaces if ($_REQUEST['submit']) {

vandango Over a year ago

And for sure, not $_REQUEST but $_POST is the right command :)

Teena Thomas · Accepted Answer · 2012-10-17 12:51:27Z

1

the name of the textarea is comment and you're using it as message in this line,

  $message = $_REQUEST['message'];

Needs to be,

 $message = $_REQUEST['comment'];

Also, the method of the form submission, needs to be POST like this,

<form action="post_comment.php" method="post" id="commentform">

answered Oct 17, 2012 at 12:51

Teena Thomas

5,2091 gold badge15 silver badges17 bronze badges

Comments

Elby · Accepted Answer · 2012-10-17 12:53:45Z

1

please change form as follows

<form action="post_comment.php" method="post" id="commentform">

In the form you can use only get/post

answered Oct 17, 2012 at 12:53

Elby

1,6743 gold badges23 silver badges43 bronze badges

Comments

wasim kazi · Accepted Answer · 2012-10-17 12:58:37Z

Try this

<form action="post_comment.php" method="post" id="commentform">

<label for="comment_author" class="required">Your Name</label>
<input name="name" id="name" tabindex="1" required="required"><br/><br/>

<label for="email" class="required">Your Email</label>
<input type="email" id="email" name="email" id="email" value="" tabindex="2"    required="required"><br/><br/>

<label for="comment" id="comment" class="required">Your Message</label><br/>

<textarea name="comment" rows="10" tabindex="4"  required="required"></textarea><br/>
<input id="submit" name="submit" type="submit" value="Submit Comment" />

and in your post page..

if ($_SERVER['REQUEST_METHOD'] === 'POST')
{
    $name = $_POST['name'];
$email = $_POST['email'];
$message = $_POST['message'];
$from = 'From: '. $email; 
$to = '[email protected]'; 
$subject = 'WEBSITE';

$body = "From: $name\n E-Mail: $email\n Message:\n $message";


$headers = "From: $from \r\n";
//$headers .= "Reply-To: $visitor_email \r\n";

mail($to, $subject, $body,$headers);
}

Dino Babu · Accepted Answer · 2012-10-17 13:06:41Z

-> Use POST instead of REQUEST

-> comment chaged to message

HTML

<form action="post_comment.php" method="post" id="commentform">
<label for="comment_author" class="required">Your Name</label>
<input name="name" id="name" tabindex="1" required="required"><br/><br/>
<label for="email" class="required">Your Email</label>
<input type="email" id="email" name="email" id="email" value="" tabindex="2"  required="required"><br/><br/>
<label for="comment" id="comment" class="required">Your Message</label><br/>
<textarea name="message" rows="10" tabindex="4"  required="required"></textarea><br/>
<input id="submit" name="submit" type="submit" value="Submit Comment" />
</form>

PHP

<?php
    $name = $_POST['name'];
    $email = $_POST['email'];
    $message = $_POST['message'];
    $from = 'From: '. $email; 
    $to = '[email protected]'; 
    $subject = 'WEBSITE';

    $body = "From: $name\n E-Mail: $email\n Message:\n $message";

    if ($_POST['submit']) {               
        if (mail($to, $subject, $body, $from)) { 
        echo '<p>Your message has been sent!</p>';
    } else { 
        echo '<p>Something went wrong, go back and try again!</p>'; 
    }}
?>

Collectives™ on Stack Overflow

Why isn't my php script working?

8 Answers 8

5 Comments

7 Comments

Comments

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

5 Comments

7 Comments

Comments

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related