PHP Script doesn't work on my form

Question

I have a HTML form, and a php script for saving the elements into a .txt file. Here's my form:

<div class="col-md-6">
    <h2>Send us a message</h2>
    <form id="contact-form" action="myscript.php" method="POST">
        <div class="row">
            <div class="col-md-6">
                <input name="name" id="name" type="text" placeholder="Name" />
                <input name="email" id="email" type="text" placeholder="E-Mail" />
                <input name="subject" id="subject" type="text" placeholder="Subject" />
            </div>

            <div class="col-md-6">
                <textarea name="comment" id="comment" placeholder="Message"></textarea>
                <input type="submit" id="submit_contact" value="Send message" />
                <div id="msg" class="message"></div>
            </div>
        </div>
    </form>                     
</div>

And my php script:

<?php
if(isset($_POST['name']) && isset($_POST['email']) && isset($_POST['subject']) && isset($_POST['comment'])) {
    $data ='Name : ' . $_POST['name'] . "\n" . 'E-Mail : ' . $_POST['email'] . "\n" . 'Website : ' . $_POST['subject'] . "\n" . 'Comment : ' . $_POST['comment'] . "\n" . '----------------------------------------------------------------' . "\n";
    $ret = file_put_contents('comments.txt', $data, FILE_APPEND);
    if($ret === false) {
        echo "<script>alert('Failure!');</script>";
    }
    else {
        echo "<script>alert('Success!');</script>";
    }
    }
    else {
      echo "<script>alert('Fill in The Form Please !');</script>";
    }

When I fill the form and press submit, nothing happens actually. But when I remove the DIV tags it works.

Here are my full codes: My HTML code and my CSS code

So it is not about the PHP script but your HTML or maybe some JS? — putvande
– putvande, Commented Feb 27, 2014 at 18:48
@relentless , i mean all of them . i removed all of them and tried again and it worked fine. — Mahdi Abdi
– Mahdi Abdi, Commented Feb 27, 2014 at 18:50
Do you have more HTML around it that you are not showing? Sounds a bit odd that a few HTML tags stop your form from submitting. — putvande
– putvande, Commented Feb 27, 2014 at 18:51
@dg988 he has a submit button, it should submit if he presses enter while any input control has focus. — Snowburnt
– Snowburnt, Commented Feb 27, 2014 at 19:18

Ryan Vincent · Accepted Answer · 2014-03-02 14:35:12Z

2

+50

Your code and the HTML as posted. Included your css.

You have an extra brace in the script.

This code shows the form and creates the 'comments.txt' file.

Added test to ensure all the fields are entered

PHP 5.3.18 on windows XP.

<?php

if (isset($_POST['myscript'])) { // the form was submitted...


    if(   isset($_POST['name'])    && !empty($_POST['name'])
       && isset($_POST['email'])   && !empty($_POST['email'])
       && isset($_POST['subject']) && !empty($_POST['subject'])
       && isset($_POST['comment']) && !empty($_POST['comment'])) {

        $data ='Name : ' . $_POST['name'] . "\n" . 'E-Mail : ' . $_POST['email'] . "\n" . 'Website : '
                . $_POST['subject'] . "\n" . 'Comment : ' . $_POST['comment'] . "\n"
                . '----------------------------------------------------------------' . "\n";
        $ret = file_put_contents('comments.txt', $data, FILE_APPEND);
        if($ret === false) {
            echo "<script>alert('Failure!');</script>";
        }
        else {
            echo "<script>alert('Success!');</script>";
        }
    }
    else {
      echo "<script>alert('Fill in The Form Please !');</script>";
    }
}
?>

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <title>Q22077564</title>
    <LINK REL=StyleSheet HREF="Q22077564.css" TYPE="text/css" MEDIA=screen>
  </head>

<body>
<div class="col-md-6">
    <h2>Send us a message</h2>
    <form id="contact-form" action="myscript.php" method="POST">
      <!-- add hidden field so that we know the form came in! -->
      <input type="hidden" name="myscript"  value="myscript" />;
      <div class="row">
            <div class="col-md-6">
                <input name="name" id="name" type="text" placeholder="Name" />
                <input name="email" id="email" type="text" placeholder="E-Mail" />
                <input name="subject" id="subject" type="text" placeholder="Subject" />
            </div>

            <div class="col-md-6">
                <textarea name="comment" id="comment" placeholder="Message"></textarea>
                <input type="submit" id="submit_contact" value="Send message" />
                <div id="msg" class="message"></div>
            </div>
        </div>
    </form>
</div>
</body>
</html>

edited Mar 2, 2014 at 14:35

answered Mar 2, 2014 at 13:55

Ryan Vincent

4,5137 gold badges24 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Mahdi Abdi Over a year ago

Thanks a lot . it works but when i run it , an alert shows "success" . and it mustn't show that at the first place. what should i do ?

Ryan Vincent Over a year ago

Ah! OK give me a few minutes and i will fix it!

BlueCacti Over a year ago

@ShaPesar if(isset($_POST['submit'])) { // form has been posted } else { // diplay form, no past has been made yet }

Ryan Vincent Over a year ago

added a hidden field to detect the form being submitted. Used your CSS. The code appends entries into the comment.txt file.

user2783998 · Accepted Answer · 2014-03-02 13:47:23Z

0

<?php
if(isset($_POST['name']) && isset($_POST['email']) && isset($_POST['subject']) && isset($_POST['comment'])) {
$data ='Name : ' . $_POST['name'] . "\n" . 'E-Mail : ' . $_POST['email'] . "\n" . 'Website : ' . $_POST['subject'] . "\n" . 'Comment : ' . $_POST['comment'] . "\n" . '----------------------------------------------------------------' . "\n";
$ret = file_put_contents('comments.txt', $data, FILE_APPEND);
if($ret === false) {
    echo "<script>alert('Failure!');</script>";
}
else {
    echo "<script>alert('Success!');</script>";
}
}
else {
  echo "<script>alert('Fill in The Form Please !');</script>";
} **}**//not your answer but you should remove this one right

answered Mar 2, 2014 at 13:47

user2783998

688 bronze badges

Collectives™ on Stack Overflow

PHP Script doesn't work on my form

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related