PHP and some global variables

Question

require_once'modules/logger.php';                                                         
$Logger = new Logger();

require_once 'templates/list.php';
$Templates = new templatesList();

require_once 'widgets/list.php';
$Widgets = new widgetsList();

I use $Logger in templates/list.php and in widgets/list.php. $Templates I use in /widgets/list.php.

The code above throws this error:

Notice: Undefined variable: Logger in .../templates/list.php on line 99 Fatal error: Call to a member function toLog() on a non-object in .../templates/list.php on line 99

UPD Here is line 99:

$Logger->toLog( $contentData );

where is your line 99? Could you post it?

SilentGhost
– SilentGhost

2009-08-27 10:39:27 +00:00
Commented Aug 27, 2009 at 10:39 — SilentGhost
– SilentGhost, Commented Aug 27, 2009 at 10:39

Tom Haigh · Accepted Answer · 2009-08-27 10:42:36Z

2

If you want to use the $Logger from within an object method, you will need to mark it as global within that method. If you don't you will end up creating a new local $Logger variable. I suspect that is what the problem is. For example:

class templatesList {
    public function __construct() {
        global $Logger;
        //now we can use $logger.
    }
}

However, it would probably be better to pass $Logger into the constructor of every object which needs to use it. Global variables are not generally considered good practise.

class templatesList {
    protected $Logger;
    public function __construct(Logger $Logger) {
        //now we can use $logger.

        //store reference we can use later
        $this->Logger = $Logger;
    }

    public function doSomething() {
        $this->Logger->log('something');
    }
}

new templatesList($Logger);

answered Aug 27, 2009 at 10:42

Tom Haigh

57.8k21 gold badges119 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Max Frai Over a year ago

I tried to use global keyword, it didn't help me. Maybe passing it into constructor will be better idea... Okay, thanks.

nikc.org Over a year ago

For a Logger and Templateslist class (which both sound like there needs only be one instance of each) I'd suggest using a singleton model. No need to pass variables or using globals.

rojoca Over a year ago

While a singleton version of Logger might be appropriate, a singleton is just a global variable in disguise

n1313 · Accepted Answer · 2009-08-27 10:42:08Z

0

Are you sure you're not unsetting $Logger somewhere in the beginning of /templates/list.php?

Try var_dumping() $Logger after its initialization and before using.

answered Aug 27, 2009 at 10:42

n1313

21.6k7 gold badges33 silver badges46 bronze badges

Collectives™ on Stack Overflow

PHP and some global variables

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related