Having trouble rendering Javascript in Rails

Question

Here's the relevant controller code:

if @song.update_attributes(params[:song])
  respond_to do |format|
    format.js {
      render :action => 'success'
    }
  end
else

Here's what's in success.js.erb:

$("#song_updated_at").val( "<%= escape_javascript @song.updated_at %>" )

Here's the error I get:

ActionView::TemplateError ($_ value need to be String (nil given)) on line #1 of app/views/songs/success.js.erb:
1: $("#song_updated_at").val( "<%= escape_javascript @song.updated_at %>" )

    app/views/songs/success.js.erb:1
    app/controllers/songs_controller.rb:52:in `update'
    app/controllers/songs_controller.rb:50:in `update'

Thoughts?

theIV · Accepted Answer · 2009-08-28 02:00:31Z

2

You need to to_s your updated_at, because escape_javascript expects a String. updated_at returns a ActiveSupport::TimeWithZone.

Hope this helps.

answered Aug 28, 2009 at 2:00

theIV

25.9k5 gold badges56 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Tom Lehman Over a year ago

ARGGHHHHH! escape_javascript should take care of this automatically!

theIV Over a year ago

I agree, I don't understand why it doesn't.

Collectives™ on Stack Overflow

Having trouble rendering Javascript in Rails

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related