Problem rendering vanilla JavaScript in Ruby

Question

In My controller I am trying to render vanilla JavaScript but am getting an unexpected result. This is the code

class UploadController < ApplicationController

    def index

        render :file => 'app\views\upload\uploadfile.rhtml'

    end

    def uploadFile

        render :js => "alert('Hello Rails');"

       post = DataFile.save(params[:upload])

    end

end

Am expecting before executing post = DataFile.save(params[:upload]) I should see a alertbox but I am seeing a download box. What could be the problem?

Are you sure you are reaching the right route? and what kind of error are you getting? — Elad Meidar
– Elad Meidar, Commented Oct 20, 2010 at 12:09
am not getting any error but when i am trying to render render :js => "alert('Hello Rails');" am getting download box from my explorer — Amit Singh Tomar
– Amit Singh Tomar, Commented Oct 20, 2010 at 12:16

Robbie · Accepted Answer · 2010-10-20 13:31:10Z

1

render :js will send data with the MIME type text/javascript Browsers will see this and attempt to download or display it (my browser, Chromium, displays .js files as plaintext.)

render :js is really meant to return some JavaScript that will be processed by code already on that page.

In essence, you can have an AJAX call from jQuery:

$.ajax({
  type: "POST",
  url: "tokens/1/destroy.js",
  data: { _method: 'DELETE', cell: dsrc.id }
});

This is some code taken from a project of mine. Here, no dataType is defined, so jQuery intelligently "guesses" what type of data is returned. It sees that it is MIME-Type: text/javascript and executes it. Which if we were to use your code, would result in an alert dialog being shown.

In essence, you need to have a page already loaded, and the page has to be waiting for the "vanilla JavaScript" to be returned.

If you just want to execute some code for that particular action, you just have to wrap it using javascript_tag in your template/view, or include an external .js file.

answered Oct 20, 2010 at 13:31

Robbie

7259 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Amit Singh Tomar Over a year ago

Robbie thanks but could you help me regarding this code(which sent by me) this is my viwe for this controller

Amit Singh Tomar Over a year ago

<h1>File Upload </h1> <%= form_tag ({:action => 'uploadFile'},:multipart => true) %> <p><label for="upload_file">Select File</label> : <%= file_field 'upload', 'datafile' %></p> <%= submit_tag "Upload" %>

Robbie Over a year ago

AMIT, I would recommend viewing some of the railscasts for dealing with javascript: railscasts.com/episodes?search=RJS

Collectives™ on Stack Overflow

Problem rendering vanilla JavaScript in Ruby

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related