JavaScript won't accept the code below, whats wrong?
<a href="#" <?php if ($tagOn) {echo 'id="tagOn"' } else {echo 'id="tagOff"' } ?>
onclick="addToSearch('xyz')">Xyz</a>
$tagOn is a Boolean.
-
1You are missing semicolons after echo statements.dev-null-dweller– dev-null-dweller2012-11-27 23:47:21 +00:00Commented Nov 27, 2012 at 23:47
Add a comment
|
4 Answers
I think it's clearer if you define the variable first. It gets confusing if you put too much logic inline.
<?php $id = $tagOn ? "tagOn" : "tagOff"; ?>
<a href="#" "<?php echo $id ?> onclick="addToSearch('xyz')">Xyz</a>
2 Comments
Nick Rolando
I don't see this setting the
id
Sae Us
Thanks all - it was the semicolons :p
You're forgetting the semi-colons after each statement, try something like this:
<a href="#" <?php if ($tagOn) { echo 'id="tagOn"'; } else { echo 'id="tagOff"'; } ?>
onclick="addToSearch('xyz')">Xyz</a>
Comments
It might just be the missing semi-colons
<a href="#" <?php if ($tagOn) { echo 'id="tagOn"'; } else { echo 'id="tagOff"'; } ?>
onclick="addToSearch('xyz')">Xyz</a>
A cleaner way of doing this is with the ternary operator:
<a href="#" id=<?php echo ($tagOn) ? '"tagOn"' : '"tagOff"'; ?>
onclick="addToSearch('xyz')">Xyz</a>
Comments
You forget semicolons !
<a href="#" <?php if ($tagOn) { echo 'id="tagOn"'; } else { echo 'id="tagOff"'; } ?>
onclick="addToSearch('xyz')">Xyz</a>
