If-else JavaScript not working

Question

Whats wrong with this script? It resets itself and the second div never changes. I'm missing something? I'm thinking I probably need a better way to handle the variable so if someone knows of one that would be awesome. This is my jsfiddle testing script:

var lang="de";

$('#en').click(function () {
    lang="en";
});
$('#de').click(function () {
    lang="de";
});
$('#es').click(function () {
    lang="es";
});

function showtext() {
    $('#text').text(lang); 
    if (lang="en") {
        $('#cur').text(lang);
    }
    else if (lang="de") {
        $('#cur').text(lang);
    }
    else if (lang="es") {
        $('#cur').text(lang);
    }
}

showtext();

setInterval(function () {
    showtext();
}, 2000);

Demo on jsfiddle

Possible duplicate: stackoverflow.com/questions/13851399/… — Ja͢ck
– Ja͢ck, Commented Feb 21, 2013 at 2:24

Jesse · Accepted Answer · 2013-03-23 02:06:55Z

4

Your function is doing assignment through =, for comparison you must use ==.

function showtext() {
    $('#text').text(lang); 
    if (lang == "en") {
        $('#cur').text(lang);
    }
    else if (lang == "de") {
        $('#cur').text(lang);
    }
    else if (lang == "es") {
        $('#cur').text(lang);
    }
}

jsFiddle Working demo

edited Mar 23, 2013 at 2:06

answered Feb 21, 2013 at 2:20

Jesse

8,7597 gold badges49 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Keleko Over a year ago

omg, I feel so dumb now, I should of seen that, Ive been racking my brain why it wasn't working lol. thanks for helping me see it!

Victor · Accepted Answer · 2013-02-21 02:21:59Z

0

Your comparisons are actually assignments try below:

$('#text').text(lang); 
    if (lang=="en"){
        $('#cur').text(lang);
    }
    else if (lang=="de"){
        $('#cur').text(lang);
    }
    else if (lang=="es"){
        $('#cur').text(lang);
    }

answered Feb 21, 2013 at 2:21

Victor

6661 gold badge5 silver badges17 bronze badges

Comments

isherwood · Accepted Answer · 2013-02-21 02:23:59Z

0

You have an if loop that does exactly nothing (and it uses the wrong comparison operator). Try this instead:

http://jsfiddle.net/Su3RC/158/

function showtext() {
    $('#text').text(lang);
    $('#cur').text(lang);
}

answered Feb 21, 2013 at 2:23

isherwood

61.4k16 gold badges122 silver badges173 bronze badges

2 Comments

Jesse Over a year ago

I believe he is wanting to learn/fix if-statements, rather than optimize his snippet of code.

isherwood Over a year ago

Fair enough. I wasn't sure.

Collectives™ on Stack Overflow

If-else JavaScript not working

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related