foreach loop issue with custom fields

Question

I have this bootstrap slider that doesn't seem to be grabbing the video links properly.

This is the code I have:

        <?php $myCarousel = get_order_field('projectdetails_image'); // use the Custom Group name 
        if( !empty( $myCarousel )) {
                foreach($myCarousel as $carousel){
                $myimg = get('projectdetails_image',1,$carousel);
                    if ( !$myimg ) {
                    $videos = get_order_field('video_vimeo');
                    foreach($videos as $video){
                        if ( get('video_vimeo',TRUE) ) {
                                echo "<div class='item active black'><div id='video-wrap'>";
                                echo get('video_vimeo',1,$video);
                                echo "</div></div>";
                        }
                        else {}
                        }   
                    }
                    if ( $myimg ) {
                        echo "<div class='item".( $counter == 0 ? ' active' : '' )."'>";
                        echo '<img src="';
                        echo $myimg;
                        echo '"/>';
                        echo "</div>";
                        $counter++;
                
                        $videos = get_order_field('video_vimeo');
                        foreach($videos as $video){
                            if ( get('video_vimeo',TRUE) ) {
                                echo "<div class='item black'><div id='video-wrap'>";
                                echo get('video_vimeo',1,$video);
                                echo "</div></div>";
                            }
                        }
                    }
                }
            }
            ?>

The bottom if statement is giving me problems:

if ( $myimg ) {
                    echo "<div class='item".( $counter == 0 ? ' active' : '' )."'>";
                    echo '<img src="';
                    echo $myimg;
                    echo '"/>';
                    echo "</div>";
                    $counter++;

                    $videos = get_order_field('video_vimeo');
                    foreach($videos as $video){
                        if ( get('video_vimeo',TRUE) ) {
                            echo "<div class='item black'><div id='video-wrap'>";
                            echo get('video_vimeo',1,$video);
                            echo "</div></div>";
                        }
                    }
                }

For some reason its outputting a <div class='item black'> after every <div class='item'> whereas I would like it to output the <div class='item black'> only after all the <div class='item'>'s have been outputted.

I hope that makes sense. If someone could just point me in the right direction that would be great.

have you tried moving the for loop?

Tushar
– Tushar

2013-03-19 16:22:53 +00:00
Commented Mar 19, 2013 at 16:22 — Tushar
– Tushar, Commented Mar 19, 2013 at 16:22
I did. Perhaps Im not moving it to the right place?

popshuvit
– popshuvit

2013-03-19 16:25:31 +00:00
Commented Mar 19, 2013 at 16:25 — popshuvit
– popshuvit, Commented Mar 19, 2013 at 16:25
Haha I moved it out of the other for loop and it worked!

popshuvit
– popshuvit

2013-03-19 16:32:36 +00:00
Commented Mar 19, 2013 at 16:32 — popshuvit
– popshuvit, Commented Mar 19, 2013 at 16:32
No problem. I posted my comment as an answer.

Tushar
– Tushar

2013-03-19 16:35:35 +00:00
Commented Mar 19, 2013 at 16:35 — Tushar
– Tushar, Commented Mar 19, 2013 at 16:35

Tushar · Accepted Answer · 2013-03-19 16:35:16Z

1

Move your for loop outside of the outer for loop, which is causing it to be executed on every iteration.

answered Mar 19, 2013 at 16:35

Tushar

8,05934 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

foreach loop issue with custom fields

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related