Functioncall to javascript not working

Question

i'm using php to generate some button that have their Id and the Id of the text they should show as parameters. But for some reason the function call doesn't seem to be working.

while($row=$query->fetch(PDO::FETCH_BOTH)) { $reviewDoor=$row[0]; $korteTekst=$row[1]; $langeTekst=$row[2];

echo "<article><h4>Review van $reviewDoor</h4>";
echo "<section>$korteTekst</section>";
if (!empty($langeTekst))
{
echo "<section id='LongReview$teller' class='LongReviews'>$langeTekst</section>";
echo "<button id='LeesMeerKnop$teller' class='LeesMeerKnoppen' onclick='readMoreLess(LeesMeerKnop$teller,LongReview$teller)'>Lees meer...</button>";
}
echo "</article>";
    $teller++;

}

the file link is working

<script src="script.js" type="text/javascript"></script>

and this is the function I'm trying to call

function readMoreLess(knopId,tekst) {

var knop=getElementById(knopId);
var review=getElementById(tekst);

window.alert("hallo");

if (knop.textContent ==="Lees meer...")
{
knop.textContent="Minder tekst..."; review.style.display="block"; }
else if (knop.textContent ==="Minder tekst...") { knop.textContent="Lees meer..."; review.style.display="none";
} }

So, what's the error console log saying in your browser? Why are you not calling getElementById on the document as you should? And please, while Dutch is a great language, try to be at least slightly consistent. Either use English like the rest of the world or name all your variables, IDs and functions in your own language. — Niels Keurentjes
– Niels Keurentjes, Commented May 17, 2013 at 16:54
ow damn, thanks :p but it's still not working :S i'm not even getting an alert — Cédric Vandelaer
– Cédric Vandelaer, Commented May 17, 2013 at 16:57
You also need to apply @Eugene's fix below. Both these problems will have been clear and visible in your error log in the browser. — Niels Keurentjes
– Niels Keurentjes, Commented May 17, 2013 at 16:58
did that too, and still nothin, this is what the console says: Uncaught SyntaxError: Unexpected token } — Cédric Vandelaer
– Cédric Vandelaer, Commented May 17, 2013 at 17:01

Eugene · Accepted Answer · 2013-05-17 16:54:05Z

3

Looks like missing quotes on params values in function call:

 echo "<button id='LeesMeerKnop$teller' class='LeesMeerKnoppen' onclick='readMoreLess(\"LeesMeerKnop$teller\",\"LongReview$teller\")'>Lees meer...</button>";

answered May 17, 2013 at 16:54

Eugene

1,9591 gold badge13 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Cédric Vandelaer Over a year ago

added quotes and and document. before the getelement function but it's still doing nothing :S

Collectives™ on Stack Overflow

Functioncall to javascript not working

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related