Having trouble with adding an ArrayList to an ArrayList of ArrayLists

Question

public class Tabel {
    private static int dimension;

    private ArrayList<ArrayList<Character>> tabel;


    public Tabel(int dimension) {

        Tabel.dimension = dimension;

        for (int i=0;i<Tabel.dimension*Tabel.dimension;i++) {
           tabel.add(new ArrayList<Character>());
        }

     }
}

When I try to debug (eclipse ide) I get a lot of weird "errors" or at the very least I encounter something I consider unexpected.

The private static int does not appear in the "variables" section of debug.

I get a NullPointerException on tabel.add(...) but when I watch the debug, it enters the for once, does not add anything in the table because when I hit "next" instead of jumping to the closing braces it jumps out of the function.

If I comment the .add it works so that's the problem (I think). Is my syntax wrong ? or should I post more code ?

Just a note: Having a static variable that gets initialized by the constructor seems like a recipe for disaster. — Keppil
– Keppil, Commented May 21, 2013 at 17:20
@Keppil This is a "thin version" I have a boolean that makes sure it only happens once, I know it's not the best way but I have no other idea. — Kalec
– Kalec, Commented May 21, 2013 at 19:20

zw324 · Accepted Answer · 2013-05-21 17:18:15Z

5

tabel is not initialized, so it is null.

Change

private ArrayList<ArrayList<Character>> tabel;

to

private ArrayList<ArrayList<Character>> tabel = new ArrayList<ArrayList<Character>>();

Or better:

private List<ArrayList<Character>> tabel = new ArrayList<ArrayList<Character>>();

since this does not tie tabel to ArrayList.

answered May 21, 2013 at 17:18

zw324

27.2k16 gold badges88 silver badges119 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Konstantin Yovkov · Accepted Answer · 2013-05-21 17:18:44Z

1

You have not initialized the private List. Do the following:

private List<ArrayList<Character>> tabel = new ArrayList<ArrayList<Character>>();

answered May 21, 2013 at 17:18

Konstantin Yovkov

63k9 gold badges107 silver badges152 bronze badges

Comments

Gilbert Le Blanc · Accepted Answer · 2013-05-21 18:06:00Z

I'd have trouble understanding that level of nesting too.

It's better to refer to List rather than ArrayList. Unless you need a method in the concrete class, it makes your program more flexible to refer to the interface and the methods in the interface.

Create a class (1) that has a field defined as a List of Character. Set the field to a new ArrayList in the constructor.

Create another class (2) that has a field defined as a List of class (1). Set the field to a new ArrayList in the constructor.

Create another class (3) that has a field defined as a List of class (2). Set the field to a new ArrayList in the constructor.

Since you understand what you're doing, you can give these 3 classes more meaningful names.

Collectives™ on Stack Overflow

Having trouble with adding an ArrayList to an ArrayList of ArrayLists

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related