Trouble adding to an ArrayList of ArrayLists

Question

Hi all I'm having trouble at the moment with one of my methods at the moment.

ArrayList<ArrayList<UnigramLanguageModel>> arrayListReadCategoriesDC() throws IOException{
    BufferedReader br = null;
    String line="";

    ArrayList<ArrayList<UnigramLanguageModel>> dcx = new ArrayList<ArrayList<UnigramLanguageModel>>();
    ArrayList<UnigramLanguageModel> ulm = new ArrayList<UnigramLanguageModel>();

    for(int i=0;i<7;i++){

        br = new BufferedReader(new FileReader("C:\\Users\\mccluskm\\Desktop\\trainingSet\\"+dcP[i]+"\\"+dc[i]+".txt"));
        while ((line = br.readLine()) != null){
            String[] split = line.split(":");
            ulm.add(new UnigramLanguageModel(split[0],Integer.parseInt(split[1]),true));
        }
        //System.out.println("Adding stage: "+ulm.size());
        dcx.add(ulm);
        //System.out.println("From within nested ArrayList: "+dcx.get(i).size());
        ulm.clear();
    }
    br.close();
    return dcx;
}

Here is my method where I read in from various files (which represent different categories). Each category gets its own ArrayList and then I want to return an ArrayList>

From within the main method I call it like this:

UnigramLanguageModel ulm = new UnigramLanguageModel ();
ArrayList<ArrayList<UnigramLanguageModel>> dc =ulm.arrayListReadCategoriesDC();

It returns an empty an arraylist holding 7 empty arraylists and I dont know why? If anyone could help I would really appreciate it!

while ((line = br.readLine()) != null){ String[] split = line.split(":"); ulm.add(new UnigramLanguageModel(split[0],Integer.parseInt(split[1]),true)); } need to check this code part. Please check if underlying .txt file gets seperated properly with : seperator. Seven arraylists got added into another arraylist because of dcx.add(ulm); — Ashish Patil
– Ashish Patil, Commented Jul 9, 2015 at 10:13
I have checked the file is read correctly and the individual elements are added to the Object correctly. Yeh I am just curious as to why it is adding empty ArrayLists despite me populating them above? — Mark McCluskey
– Mark McCluskey, Commented Jul 9, 2015 at 10:18

Ashish Patil · Accepted Answer · 2015-07-09 10:32:26Z

1

I got your problem. Please remove ulm.clear(); call from your code. This will solves your problem.

Morover declaring something like below is not good approach-

ArrayList<UnigramLanguageModel> ulm = new ArrayList<UnigramLanguageModel>();

Try instead below--

List<UnigramLanguageModel> ulm = new ArrayList<UnigramLanguageModel>();

answered Jul 9, 2015 at 10:32

Ashish Patil

4,6421 gold badge17 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dakshinamurthy Karra · Accepted Answer · 2015-07-09 10:39:18Z

1

The problem seems to be you are inserting the same reference into the topmost array list always. Instead of using ulm.clear, create a new ulm object in the loop. That should resolve the issue.

answered Jul 9, 2015 at 10:39

Dakshinamurthy Karra

5,4931 gold badge19 silver badges31 bronze badges

Collectives™ on Stack Overflow

Trouble adding to an ArrayList of ArrayLists

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related