asp.net MVC confused by custom attributes creation

Question

hi i am trying to create a custom attribute for my MVC application so that i can call [CheckLogin] this is to check my cookie as i am not using forms authentification.

i have created a class CheckLogin and this is in my App_Code folder and the code is as follows:

using System.Web.Mvc;
using System.Attributes;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Web;
using System;

namespace corian_MVC.Controllers
{
    [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, Inherited = true, AllowMultiple = true)]
    public class CheckLoginAttribute : FilterAttribute, IAuthorizationFilter
    {
        public CheckLoginAttribute() {}

        public void OnAuthorization(AuthorizationContext filterContext)
        {
            // TODO: perform your cookie checks
            if (!userIsAuthenticated)
            {
                filterContext.Result = new RedirectResult(string.Format(
                          "/Admin/Login",
                          filterContext.HttpContext.Request.Url.AbsoluteUri));
            }
        }
    }
}

what it does is not important here, the problem is i cant get my code to recognise this attribute if it is one in the first place, also how do i redirect to action if the login is failed ????

many thanks

my admin class:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.Mvc;
using System.Web.Mvc.Ajax;


namespace corian_MVC.Controllers
{
    [HandleError]
    public class AdminController : Controller
    {
        [AcceptVerbs(HttpVerbs.Get)]
        public ActionResult Index()
        {
            //check login is not banned

            if ((int)Session["LoginCount"] >= 3) RedirectToAction("TooMany");

            return View();
        }

        public ActionResult Fraud()
        {
            Session["LoginCount"] = 3;
            return View();
        }

        public ActionResult TooMany()
        {
            return View();
        }

        [CheckLogin]
        public ActionResult Welcome()
        {
            return View();
        }

        private void Createcookie()
        {

        }

    }
}

Darin Dimitrov · Accepted Answer · 2009-11-07 14:48:22Z

2

This scenario is best handled by implementing an IAuthorizationFilter.

[AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, Inherited=true, AllowMultiple=true)]
public class CheckLoginAttribute : FilterAttribute, IAuthorizationFilter
{
    public void OnAuthorization(AuthorizationContext filterContext)
    {
        // TODO: perform your cookie checks
        if (!userIsAuthenticated)
        {
            filterContext.Result = new RedirectResult(string.Format(
                "/loginUrl?ReturnUrl={0}",  
                filterContext.HttpContext.Request.Url.AbsoluteUri));
        }
    }
}

Then you can apply this attribute either at the controller level or at some particular actions.

By the way do you have any particular reason for not using the built-in FormsAuthentication?

edited Nov 7, 2009 at 14:48

answered Nov 7, 2009 at 14:43

Darin Dimitrov

1.0m275 gold badges3.3k silver badges3k bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

davethecoder Over a year ago

yeah thats great but i can not get the attribute to even be picked up in my controllers, the usual im missing an assembly reference, however there in the same namespace etc. is there something extra i have to do in order to make it available ????

Darin Dimitrov Over a year ago

Arghh, I see. You use App_Code. Well don't use this folder. This is only used for ASP.NET web sites and not web applications which the standard model for ASP.NET MVC template.

davethecoder Over a year ago

moved it from app_code to main root of site, I.E CheckLoginAttribute.cs sits next to default.aspx ?? still not picking it up

Darin Dimitrov Over a year ago

Did you actually marked any of your controller action methods with this attribute?

davethecoder Over a year ago

[CheckLogin] public ActionResult Welcome() { return View(); }

|

queen3 · Accepted Answer · 2009-11-07 15:51:15Z

-1

Include .cs file with your attribute to the solution. Just placing it "near default.aspx" is not enough.

answered Nov 7, 2009 at 15:51

queen3

15.6k8 gold badges69 silver badges122 bronze badges

1 Comment

davethecoder Over a year ago

please read below, it is no longer there it is in controllers and i have triedadding a using tag but it wont

Collectives™ on Stack Overflow

asp.net MVC confused by custom attributes creation

2 Answers 2

10 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related