c# Attributes and overriding behavior asp.net mvc

Question

I have a transaction attribute that performs a commit in the onactionexecuted method.

This is specified at the controller method, for one of my actions i need to override that method and not call the code in onactionexecuted?

Here is some sample code.

[Transaction]
public class TestController
{
    public ActionResult Index()
    {
        return View();
    }

    [NoTransaction]
    public ActionResult Test()
    {
        return View();
    }
}

The [NoTransaction] attribute should override the onactionexecuted method in [Transaction]. Is there a way to do this?

Please provide some code to illustrate your question.

John Saunders
– John Saunders

2010-01-12 23:52:26 +00:00
Commented Jan 12, 2010 at 23:52 — John Saunders
– John Saunders, Commented Jan 12, 2010 at 23:52

Haacked · Accepted Answer · 2010-01-13 01:06:45Z

All action filters have an order property. If it's not defined, it has an implicit value of -1. When filters have the same order, the order is determined by scope: is it applied to a controller or applied to an action.

Controller scoped filters of the same order run before action filters of the same order.

The simple workaround is to apply an explicit ordering in this case to the Transaction attribute.

[Transaction(Order=1)]
public class TestController
{
    public ActionResult Index()
    {
        return View();
    }

    [NoTransaction(Order=0)]
    public ActionResult Test()
    {
        return View();
    }
}

This will ensure that NoTransaction runs before Transaction does.

If you want NoTransaction to override Transaction, the simplest thing to do is to have NoTransaction add some special key in HttpContext.Items which the Transaction attribute reads. The presence of this key would tell the Transaction attribute to not do anything.

Levi · Accepted Answer · 2010-01-13 01:06:59Z

3

If your NoTransactionAttribute is a filter, you can set a flag within its OnActionExecuting() as suggested in the other post. Otherwise:

// just a marker attribute with no special logic
public sealed class NoTransactionAttribute : Attribute { }

public class TransactionAttribute : ActionFilterAttribute {
    public override void OnActionExecuted(ActionExecutedContext filterContext) {
        if (filterContext.ActionDescriptor.IsDefined(typeof(NoTransactionAttribute), true /* inherit */)
            || filterContext.ActionDescriptor.ControllerDescriptor.IsDefined(typeof(NoTransactionAttribute), true /* inherit */) {
                return; // should skip logic
        }

        // perform your logic here
    }
}

answered Jan 13, 2010 at 1:06

Levi

32.8k3 gold badges91 silver badges89 bronze badges

1 Comment

Rhys Stephens Over a year ago

It sucks that ActionDescriptor.IsDefined(typeof(Foo),true) doesn't actually use inheritance correctly. E.g. the Controller has [Authorize], which is inherited by the Action, but the method ActionDescriptor.IsDefined returns false.

ten5peed · Accepted Answer · 2010-01-13 00:15:04Z

0

In the NoTransaction attribute's OnActionExecuting you could put some sort of a flag in HttpContext.Items which you can then check for in the Transaction attribute's OnActionExecuted. Or some variation on that.

HTHs,
Charles

answered Jan 13, 2010 at 0:15

ten5peed

15.9k3 gold badges62 silver badges74 bronze badges

2 Comments

Schotime Over a year ago

Does the [NoTransaction] run first?

ten5peed Over a year ago

I think the order will be: Transaction.OnActionExecuting -> NoTransaction.OnActionExecuting -> NoTransaction.OnActionExecuted -> Transaction.OnActionExecuted

Collectives™ on Stack Overflow

c# Attributes and overriding behavior asp.net mvc

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related