function call inside a function in php not working

Question

This code is a function calling a function in php. The function call is never called.

function saveSubject(){
    $result = mysql_query("select * from term where description='".$_POST['term']."'");
    $row = mysql_fetch_array($result, MYSQL_NUM);
    global $term;
    $term = $row[0];
    $x=1;
    while(isset($_POST['subCode'.$x])and isset($_POST['subTitle'.$x]) and isset($_POST['subUnit'.$x])){
            $code = $_POST['subCode'.$x];
            $title = $_POST['subTitle'.$x];
            $unit = $_POST['subUnit'.$x];
            $query = "INSERT INTO subject(subcode, description, units, termid)
                VALUES('".$code."','".$title."',".$unit.",".$term.")";
            $result = mysql_query("SELECT * from subject where subcode='".$code."'");
            if(mysql_num_rows($result) > 0){
                $message = "Subject Code : ".$code;
                prompt($message);
            }else{
                mysql_query($query);
                savePre($code, $x);
                }
            $x++;
        }
}
function savePre($code, $y){
$pre = mysql_query("SELECT subject.subcode from subject left join term
                    on term.termid=subject.termid
                    left join curriculum on term.termid = curriculum.curriculumid
                    where term.courseid =".$_POST['course']);
    while($row = mysql_fetch_array($pre, MYSQL_NUM)){
        $c = $row[0].$y;
        if(isset($_POST[$c])){
            $result = mysql_query("Select * from pre_requisite where pre_requisites=".$row[0]."and subject=".$code);
            if(mysql_num_rows($result) > 0){
                $message = "";
            }else{
                mysql_query("INSERT into pre_requisites(pre_requisite, subject)
                    values (".$row[0].", ".$code.")");
            }
        }
    }
}

Calling function savePre() in saveSubjec() but the calling is not working. I cannot find out what is wrong. Please help!

because its not executing else statement..make sure mysql_num_rows($result) return 0 then your function will work — Dipesh Parmar
– Dipesh Parmar, Commented Jun 6, 2013 at 5:33
When you say the call is not working, what do you mean? Are you getting an error? Is the database updating? Try adding this to the end of every mysql_query() or die mysql_error(); — Dale
– Dale, Commented Jun 6, 2013 at 5:34
echo something before function call to see if the else executing or not. — Mahdi
– Mahdi, Commented Jun 6, 2013 at 5:34
write the savePre function above of the saveSubjec and then try. — Code Lღver
– Code Lღver, Commented Jun 6, 2013 at 5:35
@DipeshParmar I have done that. The query before that call is executing well. — Xelamae
– Xelamae, Commented Jun 6, 2013 at 5:36

Dipesh Parmar · Accepted Answer · 2013-06-06 05:37:07Z

1

Simple...

You code is

$query = "INSERT INTO subject(subcode, description, units, termid)
    VALUES('".$code."','".$title."',".$unit.",".$term.")";

$result = mysql_query("SELECT * from subject where subcode='".$code."'");
if(mysql_num_rows($result) > 0)
{
    $message = "Subject Code : ".$code;
    prompt($message);
}else{
    mysql_query($query);
    savePre($code, $x);
}

from above code you can imagine that you are inserting record to database and then selecting that record using subcode match where condition so it will always return 1 as output so your else condition will never get execute.

That's the reason why you are not able to call savePre function.

answered Jun 6, 2013 at 5:37

Dipesh Parmar

27.3k8 gold badges65 silver badges92 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Bharat Chodvadiya Over a year ago

he does not execute insert query before select.

Dipesh Parmar Over a year ago

ohhh Yes i did not realized it. +1 for u

Bharat Chodvadiya · Accepted Answer · 2013-06-06 05:59:46Z

You want to define savePre() function above the saveSubject() function. Use this.

function savePre($code, $y)
{
 $pre = mysql_query("SELECT subject.subcode from subject left join term
                on term.termid=subject.termid
                left join curriculum on term.termid = curriculum.curriculumid
                where term.courseid =".$_POST['course']);
 while($row = mysql_fetch_array($pre, MYSQL_NUM))
 {
    $c = $row[0].$y;
    if(isset($_POST[$c]))
    {
        $result = mysql_query("Select * from pre_requisite where pre_requisites=".$row[0]."and subject=".$code);
        if(mysql_num_rows($result) > 0){
            $message = "";
        }else{
            mysql_query("INSERT into pre_requisites(pre_requisite, subject)
                values (".$row[0].", ".$code.")");
        }
    }
 }
}

function saveSubject()
{
 $result = mysql_query("select * from term where description='".$_POST['term']."'");
 $row = mysql_fetch_array($result, MYSQL_NUM);
 global $term;
 $term = $row[0];
 $x=1;
 while(isset($_POST['subCode'.$x])and isset($_POST['subTitle'.$x]) and isset($_POST['subUnit'.$x]))
 {
        $code = $_POST['subCode'.$x];
        $title = $_POST['subTitle'.$x];
        $unit = $_POST['subUnit'.$x];

        $result = mysql_query("SELECT * from subject where subcode='".$code."'");
        if(mysql_num_rows($result) > 0){
            $message = "Subject Code : ".$code;
            prompt($message);
        }
        else
        {
           $query = "INSERT INTO subject(subcode, description, units, termid)
            VALUES('".$code."','".$title."',".$unit.",".$term.")";
            mysql_query($query);

            savePre($code, $x);
            }
        $x++;
   }
}

Collectives™ on Stack Overflow

function call inside a function in php not working

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related