Change string element value in vector

Question

I'm working on right now with string in vector . And i got my self in dead end . I've manipulate with vector<int> elements, and understand how to work with them ! I know how to work with string ! But i can't get thru the part where i need to change string element value in vector .I mean i don't know what to do in loop with "do something". So to be short i give the task on witch i work right now.

Read a sequence of words from cin and store values in vector.After you've read all words,process the vector and change each word to uppercase

Here what I've got so far

int main ()  
{
    vector<string> words;    //Container for all input word
    string inp;              //inp variable will process all input 

    while (cin>>inp)         //read
       words.push_back(inp); //Storing words 

    //Processing vector to make all word Uppercase
    for (int i = 0; i <words.size(); ++i)
     //do something

         words[i]=toupper(i);
    for (auto &e : words)    //for each element in vector 
     //do something

     cout<<e;

    keep_window_open("~");
    return 0;
}

This first for statement is not right i try access vector elements and change words to upper but it did't work for me its just sample
I've try many ways to access the vector element but when trying to use string member functions toupper() on vector i'm getting messy with code and logical mistakes!
Thanks For your time . Sorry for mistakes i made in spelling words

toupper only works on single characters. You might try combining it with std::transform. — Qaz
– Qaz, Commented Jun 8, 2013 at 23:43
toupper work with whole string in rangebase for statement. — AlexGreat
– AlexGreat, Commented Jun 8, 2013 at 23:45
Applying toupper to the index surely won't give anything useful. — celtschk
– celtschk, Commented Jun 8, 2013 at 23:45

celtschk · Accepted Answer · 2013-06-09 00:16:37Z

4

Try this:

for (auto& word: words)
  for (auto& letter: word)
    letter = std::toupper(letter);

answered Jun 9, 2013 at 0:16

celtschk

19.8k4 gold badges42 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

AlexGreat Over a year ago

THANK YOU ! that what i need . OMG itslook so simple

Super Cat Over a year ago

There's no need to manually iterate through each char when you have ranged loops - By far this is the best solution!

David G · Accepted Answer · 2013-06-09 00:25:21Z

2

This can be fixed by using the std::transform Standard algorithm to iterate through the characters of the words. You can also use std::for_each instead of the manual loop.

#include <string>
#include <algorithm>
#include <iostream>
#include <cctype>
#include <vector>

int main()  
{
    std::vector<std::string> words;
    std::string inp;

    while (std::cin >> inp)
       words.push_back(inp);

    std::for_each(words.begin(), words.end(), [] (std::string& word)
    {
        std::transform(
            word.begin(),
            word.end(), 
            word.begin(), (int (&)(int)) std::toupper
        );
    })

    for (auto &e : words)
        std::cout << e << std::endl;
}

And here is a demo.

edited Jun 9, 2013 at 0:25

answered Jun 8, 2013 at 23:57

David G

97.6k41 gold badges173 silver badges258 bronze badges

5 Comments

AlexGreat Over a year ago

Not working out ! std has no member toupper ! and also got 8 errors in that code all of them about transform function!

David G Over a year ago

@AlexGreat Include the header <cctype> and use my latest update.

AlexGreat Over a year ago

`Error 3 error C2440: '=' : cannot convert from 'int' to 'std::basic_string<_Elem,_Traits,_Alloc>'

AlexGreat Over a year ago

Error 2 error C2664: 'int (int)' : cannot convert parameter 1 from 'std::basic_string<_Elem,_Traits,_Alloc>' to 'int'

David G Over a year ago

@AlexGreat Okay, please use my newest update. I provided the entire new program.

jh314 · Accepted Answer · 2013-06-08 23:59:07Z

0

You can do this in the first for loop:

string w = words.at(i);
std::transform(w.begin(), w.end(), w.begin(), ::toupper);

edited Jun 8, 2013 at 23:59

answered Jun 8, 2013 at 23:49

jh314

27.9k16 gold badges66 silver badges83 bronze badges

1 Comment

AlexGreat Over a year ago

it helps ! but it uppercase first index element. I need uppercase all chars in vector

Collectives™ on Stack Overflow

Change string element value in vector

3 Answers 3

2 Comments

5 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related