jQuery variable issue

Question

Quick overview, when a user clicks a link with an anchor tag it opens the closest hidden div to that anchor on the destination page.

My problem seems pretty basic I just can't figure it out.

Why does this work(specifying the variable to set the height to, in this case height7):

var height7 =  100;

if(window.location.hash) {
      var hash = window.location.hash.substring(1); 
      $('a[name='+hash+']').closest('[id^="option"]').show();
      $('a[name='+hash+']').closest('[id^="option"]').height(height7);
} else {
      // No hash found
}

And this not work(in this case trying to build the name of the div i want to open, place it in a variable and passing it to the height() function exactly as above, for some reason it doesn't accept the variable):

if(window.location.hash) {
     var hash = window.location.hash.substring(1); 
     var option_name = $('a[name='+hash+']').closest('[id^="option"]').attr("id");
     var hash_div_height_id = "height" + option_name.substring(6);
     alert(hash_div_height_id);
     $('a[name='+hash+']').closest('[id^="option"]').show();
     $('a[name='+hash+']').closest('[id^="option"]').height(hash_div_height_id);
} else {
      // No hash found
}

I think that you should use .slice instead of .substring stackoverflow.com/questions/2243824/… — Andreas Louv
– Andreas Louv, Commented Jun 17, 2013 at 22:36

ikumen · Accepted Answer · 2013-06-17 22:32:11Z

1

You're assigning different values in each case:

$('a[name='+hash+']').closest('[id^="option"]').height(height7); //height = 100

$('a[name='+hash+']').closest('[id^="option"]').height(hash_div_height_id); //height = "height" + option_name.substring(6)

answered Jun 17, 2013 at 22:32

ikumen

11.7k4 gold badges43 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

javArc Over a year ago

Thanks, should have realized that.

Sushanth -- · Accepted Answer · 2013-06-17 22:36:54Z

1

You seem to be assigning a string value

var hash_div_height_id = "height" + option_name.substring(6);

     .height(hash_div_height_id);

Where as it is supposed to be a number.

So hash_div_height_id will be something like height + something

When setting a height property it expects

An integer representing the number of pixels, or an integer with an optional unit of measure appended (as a string).

edited Jun 17, 2013 at 22:36

answered Jun 17, 2013 at 22:30

Sushanth --

55.8k9 gold badges70 silver badges109 bronze badges

2 Comments

javArc Over a year ago

Thanks for identifying my issue. Now I have the slightly bigger problem of figuring out how to take the string "height7" and somehow using that to find out the value of the variable height7.

Sushanth -- Over a year ago

It is difficult to say without taking a look at the HTML

Collectives™ on Stack Overflow

jQuery variable issue

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related