Jquery variable not set

Question

In the top part of my document I have this Jquery code:

// RATING 
$('.rateit').click(function(){
var position = $(this).position();
});

In the footer I have a ajax call:

  jQuery.ajax({
             url: frm.attr('action'), //your server side script
             data: frm.serialize(), //our data
             type: 'POST',
             success: function (data) {
            alert(position.left);
            },

The problem is that the alert box is not showing with the position. I have tested with alert('something'); and it works fine.

My real ajax call:

 jQuery.ajax({
     url: frm.attr('action'), //your server side script
     data: frm.serialize(), //our data
     type: 'POST',
     success: function (data) {
    $('.warning').fadeIn(500).css({display: 'block',
        position: 'absolute',
        left: position.left + 50,
        top: position.top - 25
    }).append('asdasdsadsad'),
    $(ri).next('.ratingcount').html('asdasdasd')
    },
     error: function (jxhr, msg, err) {
         alert(msg); //something went wrong.
     }
 });

Paulo Rodrigues · Accepted Answer · 2012-02-26 13:02:31Z

3

On click function, position is a local variable, so will only be visible in this scope.

Try this:

var position;

$('.rateit').click(function(){
    position = $(this).position();
});

answered Feb 26, 2012 at 13:02

Paulo Rodrigues

5,3237 gold badges37 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Rails beginner Over a year ago

I have updated my question with my full ajax call. The position is not set for the warning div.

Paulo Rodrigues Over a year ago

When this ajax is called? You need set position before Ajax call, not on click.

Paulo Rodrigues Over a year ago

Or call ajax function on click .rateit element.

James Allardice · Accepted Answer · 2012-02-26 13:02:40Z

1

You declare position inside the anonymous function used as a click event handler. That means it won't be in scope when you try to alert it (you will get a ReferenceError).

You will need to declare position outside of the event handler function:

var position;
$('.rateit').click(function(){
    position = $(this).position();
});

However, you will still get an error if the click event handler hasn't been executed when your alert runs, because position will be undefined and therefore won't have a left property.

answered Feb 26, 2012 at 13:02

James Allardice

166k22 gold badges335 silver badges315 bronze badges

6 Comments

Rails beginner Over a year ago

Still the position is not set in the ajax call.

Rails beginner Over a year ago

I have updated my question with my real ajax call. The position is not set for the div warning.

Anthony Grist Over a year ago

@Railsbeginner That's because your position variable is set in response to an event from the user (clicking on an element), and your AJAX call is simply fired off as soon as the code is loaded.

Rails beginner Over a year ago

what is a solution for that problem?

Anthony Grist Over a year ago

@Railsbeginner Either fire off the AJAX call in response to the same event or get the position in the success callback function for the AJAX call. Or both, I guess.

|

Adaz · Accepted Answer · 2012-02-26 13:02:40Z

0

I's because your variable is defined inside $('.rateit').click(); try that:

var position;

$('.rateit').click(function(){
position = $(this).position();
});

answered Feb 26, 2012 at 13:02

Adaz

1,66512 silver badges14 bronze badges

Collectives™ on Stack Overflow

Jquery variable not set

3 Answers 3

3 Comments

6 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

6 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related